Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 116903002: Revert of [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension. (Closed)

Created:
7 years ago by szym
Modified:
7 years ago
Reviewers:
bulach, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, rmistry1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/108333004/ Reason for revert: Fails on ChromiumOS on main waterfall. TBR=tonyg@chromium.org,bulach@chromium.org NOTREECHECKS=true NOTRY=true BUG=323813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -421 lines) Patch
M tools/telemetry/telemetry/core/bitmap.py View 6 chunks +66 lines, -45 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap_unittest.py View 3 chunks +0 lines, -30 lines 0 comments Download
D tools/telemetry/telemetry/core/bitmaptools/__init__.py View 1 chunk +0 lines, -72 lines 0 comments Download
D tools/telemetry/telemetry/core/bitmaptools/bitmaptools.cc View 1 chunk +0 lines, -263 lines 0 comments Download
M tools/telemetry/telemetry/core/tab.py View 2 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
szym
Created Revert of [telemetry] Implement per-pixel algorithms in Bitmap as a C++ extension.
7 years ago (2013-12-17 00:35:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/116903002/1
7 years ago (2013-12-17 00:40:32 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/core/bitmap_unittest.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-17 00:40:34 UTC) #3
szym
rmistry: This one has issues both with CQ and with "patchset too large to download".
7 years ago (2013-12-17 00:55:14 UTC) #4
rmistry
7 years ago (2013-12-17 01:55:40 UTC) #5
Message was sent while issue was closed.
On 2013/12/17 00:55:14, szym wrote:
> rmistry: This one has issues both with CQ and with "patchset too large to
> download".

Note to self:
"patch unexpectedly ends in middle of line" is due to-
This error seems to occur when the patch file ends on a line that includes
nothing but whitespace characters. Patch files should always end with a Unix
return character. If you encounter this error, check to see that the last line
of your patch does not contain whitespace characters.

"patchset too large to download":
This needs to be investigated, seems to not cause revert failures and can see
individual patches, but cannot see the complete patch due to do this.

Powered by Google App Engine
This is Rietveld 408576698