Oilpan: Prepare moving AccessibilityText to the heap

Oilpan: Prepare moving AccessibilityText to the heap

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197619

[haraken, 2015-06-11 11:10:55]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-06-11 11:10:55]

LGTM

https://codereview.chromium.org/1169023003/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXObject.h (right):

https://codereview.chromium.org/1169023003/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXObject.h:222: static
PassOwnPtrWillBeRawPtr<AccessibilityText> create(const String& t, const
AccessibilityTextSource& s, const RefPtrWillBeRawPtr<AXObject> element)

t => text
s => textSource

https://codereview.chromium.org/1169023003/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXObject.h:239: , m_textSource(s)

Ditto.

[dmazzoni, 2015-06-11 16:20:33]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2015-06-11 16:20:34]

lgtm

[keishi, 2015-06-22 16:52:07]

https://codereview.chromium.org/1169023003/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXObject.h (right):

https://codereview.chromium.org/1169023003/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXObject.h:222: static
PassOwnPtrWillBeRawPtr<AccessibilityText> create(const String& t, const
AccessibilityTextSource& s, const RefPtrWillBeRawPtr<AXObject> element)
On 2015/06/11 11:10:55, haraken wrote:
> 
> t => text
> s => textSource

Done.

https://codereview.chromium.org/1169023003/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXObject.h:239: , m_textSource(s)
On 2015/06/11 11:10:55, haraken wrote:
> 
> Ditto.

Done.

[keishi, 2015-06-22 16:52:10]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-06-22 16:52:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1169023003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-22 16:52:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169023003/40001

[commit-bot: I haz the power, 2015-06-22 17:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 17:02:13]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[keishi, 2015-06-23 01:02:58]

The CQ bit was checked by keishi@chromium.org

[keishi, 2015-06-23 01:02:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1169023003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2015-06-23 01:03:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1169023003/60001

[commit-bot: I haz the power, 2015-06-23 02:15:10]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197619