Chromium Code Reviews Chromium Code Reviews
Issue 1169003002:
Fix animation of auto for -webkit-column-count and -webkit-column-width (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <meta charset="UTF-8"> | 2 <meta charset="UTF-8"> |
| 3 <style> | 3 <style> |
| 4 .target { | 4 .target { |
| 5 width: 300px; | 5 width: 300px; |
| 6 height: 80px; | 6 height: 80px; |
| 7 background-color: black; | 7 background-color: black; |
| 8 display: inline-block; | 8 display: inline-block; |
| 9 margin: 18px; | 9 margin: 18px; |
| 10 color: orange; | 10 color: orange; |
| 11 overflow: hidden; | 11 overflow: hidden; |
| 12 } | 12 } |
| 13 .expected { | 13 .expected { |
| 14 background-color: green; | 14 background-color: green; |
| 15 } | 15 } |
| 16 </style> | 16 </style> |
| 17 <body> | 17 <body> |
| 18 <template id="target-template"> | 18 <template id="target-template"> |
| 19 <div>Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</div> | 19 <div>Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</div> |
| 20 </template> | 20 </template> |
| 21 <script src="resources/interpolation-test.js"></script> | 21 <script src="resources/interpolation-test.js"></script> |
| 22 <script> | 22 <script> |
| 23 assertNoInterpolation({ | |
| 24 property: '-webkit-column-count', | |
| 25 from: 'auto', | |
| 26 to: '5' | |
| 27 }); | |
| 28 | |
| 23 assertInterpolation({ | 29 assertInterpolation({ |
| 24 property: '-webkit-column-count', | 30 property: '-webkit-column-count', |
| 25 from: '1', | 31 from: '1', |
| 26 to: '6' | 32 to: '6' |
| 27 }, [ | 33 }, [ |
| 28 {at: -0.4, is: '1'}, // Must be strictly positive | 34 {at: -0.4, is: '1'}, // Must be strictly positive |
| 29 {at: -0.2, is: '1'}, // Must be strictly positive | 35 {at: -0.2, is: '1'}, // Must be strictly positive |
| 30 {at: 0, is: '1'}, | 36 {at: 0, is: '1'}, |
| 31 {at: 0.2, is: '2'}, | 37 {at: 0.2, is: '2'}, |
| 32 {at: 0.4, is: '3'}, | 38 {at: 0.4, is: '3'}, |
| 33 {at: 0.6, is: '4'}, | 39 {at: 0.6, is: '4'}, |
| 34 {at: 0.8, is: '5'}, | 40 {at: 0.8, is: '5'}, |
| 35 {at: 1, is: '6'}, | 41 {at: 1, is: '6'}, |
| 36 {at: 1.2, is: '7'} | 42 {at: 1.2, is: '7'} |
| 37 ]); | 43 ]); |
| 38 | 44 |
| 39 // Zero is an invalid value, so this is equivalent to animating from 'auto' to | 45 // Zero is an invalid value, so this is equivalent to animating from 'auto' to |
| 40 // 5. | 46 // 5. |
| 41 assertInterpolation({ | 47 assertInterpolation({ |
| 42 property: '-webkit-column-count', | 48 property: '-webkit-column-count', |
| 43 from: '0', | 49 from: '1', |
|
alancutter (OOO until 2018)
2015/06/19 04:31:44
0 is not a valid value here.
| |
| 44 to: '5' | 50 to: '5' |
| 45 }, [ | 51 }, [ |
| 46 {at: -0.5, is: '1'}, // Must be strictly positive | 52 {at: -0.5, is: '1'}, // Must be strictly positive |
| 47 {at: -0.25, is: '1'}, // Must be strictly positive | 53 {at: -0.25, is: '1'}, // Must be strictly positive |
| 48 {at: 0, is: '1'}, | 54 {at: 0, is: '1'}, |
| 49 {at: 0.25, is: '2'}, | 55 {at: 0.25, is: '2'}, |
| 50 {at: 0.5, is: '3'}, | 56 {at: 0.5, is: '3'}, |
| 51 {at: 0.75, is: '4'}, | 57 {at: 0.75, is: '4'}, |
| 52 {at: 1, is: '5'}, | 58 {at: 1, is: '5'}, |
| 53 {at: 1.25, is: '6'} | 59 {at: 1.25, is: '6'} |
| 54 ]); | 60 ]); |
| 55 </script> | 61 </script> |
| 56 </body> | 62 </body> |
| OLD | NEW |
