Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 1169003002: Fix animation of auto for -webkit-column-count and -webkit-column-width (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
dstockwell, samli
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix animation of auto for -webkit-column-count and -webkit-column-width The CSSAnimatableValueFactory did not support the auto keyword for -webkit-column-count or -webkit-column-width. This patch adds support for auto being animated with these properties. BUG=498063 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197469

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M LayoutTests/animations/interpolation/webkit-column-count-interpolation.html View 2 chunks +7 lines, -1 line 1 comment Download
M LayoutTests/animations/interpolation/webkit-column-width-interpolation.html View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2015-06-09 01:18:31 UTC) #2
alancutter (OOO until 2018)
samli: Poke. https://codereview.chromium.org/1169003002/diff/1/LayoutTests/animations/interpolation/webkit-column-count-interpolation.html File LayoutTests/animations/interpolation/webkit-column-count-interpolation.html (right): https://codereview.chromium.org/1169003002/diff/1/LayoutTests/animations/interpolation/webkit-column-count-interpolation.html#newcode49 LayoutTests/animations/interpolation/webkit-column-count-interpolation.html:49: from: '1', 0 is not a valid ...
4 years, 10 months ago (2015-06-19 04:31:45 UTC) #3
dstockwell
lgtm
4 years, 10 months ago (2015-06-19 05:03:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169003002/1
4 years, 10 months ago (2015-06-19 06:21:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67402)
4 years, 10 months ago (2015-06-19 09:24:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1169003002/1
4 years, 10 months ago (2015-06-19 12:36:30 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 13:26:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197469

Powered by Google App Engine
This is Rietveld 408576698