gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc - Issue 1168993002: Update the native_viewport interface to allow specification of the surface configuration, currently…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc

Issue 1168993002: Update the native_viewport interface to allow specification of the surface configuration, currently… (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Requested fixes and a few other minor corrections Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc ('k') | gpu/command_buffer/service/in_process_command_buffer.h » ('j') | gpu/command_buffer/service/in_process_command_buffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc

diff --git a/gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc b/gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc

index 47cdf9e1988065175a861c5a5e630f780d2b64fa..45e5e5cb2e4afed0e0d34b2cd1fcdbe3aa914573 100644

--- a/gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc

+++ b/gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc

@@ -92,7 +92,8 @@ class TransferThread : public base::Thread {

return;

}

- surface_ = gfx::GLSurface::CreateOffscreenGLSurface(gfx::Size(1, 1));

+ surface_ = gfx::GLSurface::CreateOffscreenGLSurface(

+ gfx::Size(1, 1), gfx::SurfaceConfiguration());

if (!surface_.get()) {

LOG(ERROR) << "Unable to create GLSurface";

caller_wait->Signal();