Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: ui/gl/gl_surface_egl.h

Issue 1168993002: Update the native_viewport interface to allow specification of the surface configuration, currently… (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix header issue Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_surface_egl.h
diff --git a/ui/gl/gl_surface_egl.h b/ui/gl/gl_surface_egl.h
index a80843e420a543933f4e01cad2ff7b78a5837b8f..655f90a8eed9056e5e660e8072eee9734b3357df 100644
--- a/ui/gl/gl_surface_egl.h
+++ b/ui/gl/gl_surface_egl.h
@@ -22,7 +22,7 @@ EGLNativeDisplayType GetPlatformDefaultEGLNativeDisplay();
// Interface for EGL surface.
class GL_EXPORT GLSurfaceEGL : public GLSurface {
public:
- GLSurfaceEGL();
+ GLSurfaceEGL(SurfaceConfiguration requested_configuration);
viettrungluu 2015/06/09 00:48:15 nit: explicit
iansf 2015/06/09 01:52:05 Done.
// Implement GLSurface.
void DestroyAndTerminateDisplay() override;
@@ -50,7 +50,8 @@ class GL_EXPORT GLSurfaceEGL : public GLSurface {
// Encapsulates an EGL surface bound to a view.
class GL_EXPORT NativeViewGLSurfaceEGL : public GLSurfaceEGL {
public:
- explicit NativeViewGLSurfaceEGL(EGLNativeWindowType window);
+ explicit NativeViewGLSurfaceEGL(EGLNativeWindowType window,
viettrungluu 2015/06/09 00:48:15 nit: explicit no longer needed
+ SurfaceConfiguration requested_configuration);
// Implement GLSurface.
EGLConfig GetConfig() override;
@@ -93,7 +94,8 @@ class GL_EXPORT NativeViewGLSurfaceEGL : public GLSurfaceEGL {
// Encapsulates a pbuffer EGL surface.
class GL_EXPORT PbufferGLSurfaceEGL : public GLSurfaceEGL {
public:
- explicit PbufferGLSurfaceEGL(const gfx::Size& size);
+ explicit PbufferGLSurfaceEGL(const gfx::Size& size,
viettrungluu 2015/06/09 00:48:15 "
iansf 2015/06/09 01:52:05 Done.
+ SurfaceConfiguration requested_configuration);
// Implement GLSurface.
EGLConfig GetConfig() override;
@@ -112,6 +114,7 @@ class GL_EXPORT PbufferGLSurfaceEGL : public GLSurfaceEGL {
private:
gfx::Size size_;
EGLSurface surface_;
+ EGLConfig config_;
DISALLOW_COPY_AND_ASSIGN(PbufferGLSurfaceEGL);
};
@@ -121,7 +124,8 @@ class GL_EXPORT PbufferGLSurfaceEGL : public GLSurfaceEGL {
// need to create a dummy EGLsurface in case we render to client API targets.
class GL_EXPORT SurfacelessEGL : public GLSurfaceEGL {
public:
- explicit SurfacelessEGL(const gfx::Size& size);
+ explicit SurfacelessEGL(const gfx::Size& size,
viettrungluu 2015/06/09 00:48:15 "
iansf 2015/06/09 01:52:05 Done.
+ SurfaceConfiguration requested_configuration);
// Implement GLSurface.
EGLConfig GetConfig() override;

Powered by Google App Engine
This is Rietveld 408576698