Update the native_viewport interface to allow specification of the surface configuration, currently…

services/native_viewport/native_viewport_impl.cc

Index: services/native_viewport/native_viewport_impl.cc
diff --git a/services/native_viewport/native_viewport_impl.cc b/services/native_viewport/native_viewport_impl.cc
index f39f53b3f9bad9bf35df8d60a8d2dc9442a3bc8d..7dddd709de0c649ca2bcf6fe4a09278320fe1f4f 100644
--- a/services/native_viewport/native_viewport_impl.cc
+++ b/services/native_viewport/native_viewport_impl.cc
@@ -10,10 +10,14 @@
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
+#include "mojo/converters/native_viewport/surface_configuration_type_converters.h"
 #include "mojo/public/cpp/application/interface_factory.h"
 #include "services/gles2/gpu_state.h"
 #include "services/native_viewport/platform_viewport_headless.h"
 #include "ui/events/event.h"
+#include "ui/gl/gl_implementation.h"
+#include "ui/gl/gl_surface.h"
+#include "ui/gl/gl_surface_egl.h"
 
 namespace native_viewport {
 
@@ -36,10 +40,14 @@ NativeViewportImpl::~NativeViewportImpl() {
   platform_viewport_.reset();
 }
 
-void NativeViewportImpl::Create(mojo::SizePtr size,
-                                const CreateCallback& callback) {
+void NativeViewportImpl::Create(
+    mojo::SizePtr size,
+    mojo::SurfaceConfigurationPtr requested_configuration,
+    const CreateCallback& callback) {
   create_callback_ = callback;
   metrics_->size = size.Clone();
+  context_provider_.SetSurfaceConfiguration(
+      requested_configuration.To<gfx::SurfaceConfiguration>());

[viettrungluu, 2015/06/09 00:48:15]

Is there any validation of requested_configuration that you should do here?

[iansf, 2015/06/09 01:52:05]

I wonder if the validation should be done in a platform-specific manner in each
of the gl_surface_*.cc's?  I imagine there will be some configurations that are
invalid on some platforms but not on others.  For example, I think that 565
surfaces may not be available on desktop configs.

[viettrungluu, 2015/06/09 22:18:07]

The other possibility (or maybe even requirement) is to make sure that there's a
clean (with respect to the native viewport service) failure path if/when things
fail later on.

[iansf, 2015/06/09 22:29:06]

Do you have a suggestion for how that would look?  Currently in debug builds it
will log and crash if eglChooseConfig fails.  In release builds it will just log
(and presumably display a black screen).  These are both the same behavior as
before, although they happen slightly later in app startup.  I felt like
changing the error reporting mechanism was out-of-scope for this set of fixes,
but I'm happy to discuss what such a mechanism would look like.

   if (is_headless_)
     platform_viewport_ = PlatformViewportHeadless::Create(this);
   else