Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: mojo/services/native_viewport/public/interfaces/native_viewport.mojom

Issue 1168993002: Update the native_viewport interface to allow specification of the surface configuration, currently… (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix header issue Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/native_viewport/public/interfaces/native_viewport.mojom
diff --git a/mojo/services/native_viewport/public/interfaces/native_viewport.mojom b/mojo/services/native_viewport/public/interfaces/native_viewport.mojom
index 21cace63071dda8b53476cde964a057d866ea9b0..e3b86536e41d74aeb6c3ce3f3a1b124298f7fe6c 100644
--- a/mojo/services/native_viewport/public/interfaces/native_viewport.mojom
+++ b/mojo/services/native_viewport/public/interfaces/native_viewport.mojom
@@ -13,10 +13,19 @@ struct ViewportMetrics {
float device_pixel_ratio = 1.0;
};
+struct SurfaceConfiguration {
+ uint8 red_bits = 8;
+ uint8 green_bits = 8;
+ uint8 blue_bits = 8;
+ uint8 alpha_bits = 8;
+ uint8 depth_bits;
+ uint8 stencil_bits;
+};
+
interface NativeViewport {
// TODO(sky): having a create function is awkward. Should there be a factory
// to create the NativeViewport that takes the size?
- Create(Size size) => (ViewportMetrics metrics);
+ Create(Size size, SurfaceConfiguration requested_configuration) => (ViewportMetrics metrics);
viettrungluu 2015/06/09 00:48:15 Did you consider letting this parameter be nullabl
iansf 2015/06/09 01:52:05 Done.
Show();
Hide();

Powered by Google App Engine
This is Rietveld 408576698