Update the native_viewport interface to allow specification of the surface configuration, currently…

ui/gl/gl_surface_android.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface.h"
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "third_party/khronos/EGL/egl.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 13 matching lines @@
         return false;
       }
     default:
       break;
   }
   return true;
 }
 
 // static
 scoped_refptr<GLSurface> GLSurface::CreateViewGLSurface(
-    gfx::AcceleratedWidget window) {
+    gfx::AcceleratedWidget window,
+    SurfaceConfiguration requested_configuration) {

[abarth-chromium, 2015/06/09 00:30:22]

const gfx::SurfaceConfiguration&

Below you use the gfx:: namespace.  We should make it consistent one way or
another.

[iansf, 2015/06/09 01:52:05]

Done.

   CHECK_NE(kGLImplementationNone, GetGLImplementation());
   if (GetGLImplementation() == kGLImplementationOSMesaGL) {
-    scoped_refptr<GLSurface> surface(new GLSurfaceOSMesaHeadless());
+    scoped_refptr<GLSurface> surface(
+        new GLSurfaceOSMesaHeadless(SurfaceConfiguration()));
     if (!surface->Initialize())
       return NULL;
     return surface;
   }
   DCHECK(GetGLImplementation() == kGLImplementationEGLGLES2);
   if (window != kNullAcceleratedWidget) {
-    scoped_refptr<GLSurface> surface = new NativeViewGLSurfaceEGL(window);
+    scoped_refptr<GLSurface> surface =
+        new NativeViewGLSurfaceEGL(window, requested_configuration);
     if (surface->Initialize())
       return surface;
   } else {
-    scoped_refptr<GLSurface> surface = new GLSurfaceStub();
+    scoped_refptr<GLSurface> surface =
+        new GLSurfaceStub(requested_configuration);
     if (surface->Initialize())
       return surface;
   }
   return NULL;
 }
 
 // static
 scoped_refptr<GLSurface> GLSurface::CreateOffscreenGLSurface(
-    const gfx::Size& size) {
+    const gfx::Size& size,
+    gfx::SurfaceConfiguration requested_configuration) {

[abarth-chromium, 2015/06/09 00:30:22]

const gfx::SurfaceConfiguration&

[iansf, 2015/06/09 01:52:04]

Done.

   CHECK_NE(kGLImplementationNone, GetGLImplementation());
   switch (GetGLImplementation()) {
     case kGLImplementationOSMesaGL: {
-      scoped_refptr<GLSurface> surface(
-          new GLSurfaceOSMesa(OSMesaSurfaceFormatBGRA, size));
+      scoped_refptr<GLSurface> surface(new GLSurfaceOSMesa(
+          OSMesaSurfaceFormatBGRA, size, requested_configuration));
       if (!surface->Initialize())
         return NULL;
 
       return surface;
     }
     case kGLImplementationEGLGLES2: {
       scoped_refptr<GLSurface> surface;
       if (GLSurfaceEGL::IsEGLSurfacelessContextSupported() &&
           (size.width() == 0 && size.height() == 0)) {
-        surface = new SurfacelessEGL(size);
+        surface = new SurfacelessEGL(size, requested_configuration);
       } else {
-        surface = new PbufferGLSurfaceEGL(size);
+        surface = new PbufferGLSurfaceEGL(size, requested_configuration);
       }
 
       if (!surface->Initialize())
         return NULL;
       return surface;
     }
     default:
       NOTREACHED();
       return NULL;
   }
 }
 
 EGLNativeDisplayType GetPlatformDefaultEGLNativeDisplay() {
   return EGL_DEFAULT_DISPLAY;
 }
 
 }  // namespace gfx