Update the native_viewport interface to allow specification of the surface configuration, currently…

services/native_viewport/onscreen_context_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/native_viewport/onscreen_context_provider.h"
 
 #include "services/gles2/command_buffer_driver.h"
 #include "services/gles2/gpu_state.h"
 
 namespace native_viewport {
 
 OnscreenContextProvider::OnscreenContextProvider(
     const scoped_refptr<gles2::GpuState>& state)
-    : command_buffer_impl_(nullptr),
+    : requested_configuration_(gfx::SurfaceConfiguration()),
+      command_buffer_impl_(nullptr),
       state_(state),
       widget_(gfx::kNullAcceleratedWidget),
       binding_(this) {
 }
 
 OnscreenContextProvider::~OnscreenContextProvider() {
   if (command_buffer_impl_)
     command_buffer_impl_->set_observer(nullptr);
 }
 
@@ skipping 12 matching lines @@
     }
     return;
   }
 
   if (pending_create_callback_.is_null())
     return;
 
   CreateAndReturnCommandBuffer();
 }
 
+void OnscreenContextProvider::SetSurfaceConfiguration(
+    gfx::SurfaceConfiguration requested_configuration) {
+  requested_configuration_ = requested_configuration;
+}

[abarth-chromium, 2015/06/09 00:30:21]

This function should be defined in the header and should be named
set_surface_configuration.  The difference between StudlyCaps and unix_hacker
names is that unix_hacker names are for trivial getters/setters.  That way you
can see from the call site that calling set_surface_configuration won't have any
nutty side effects.  By contrast SetAcceleratedWidget causes all kinds of side
effects and hence has the StudlyCaps name.

[iansf, 2015/06/09 01:52:04]

Done.

+
 void OnscreenContextProvider::Create(
     mojo::ViewportParameterListenerPtr viewport_parameter_listener,
     const CreateCallback& callback) {
   if (!pending_create_callback_.is_null()) {
     DCHECK(!command_buffer_impl_);
     pending_create_callback_.Run(nullptr);
   }
+
   pending_listener_ = viewport_parameter_listener.Pass();
   pending_create_callback_ = callback;
 
   if (widget_ != gfx::kNullAcceleratedWidget)
     CreateAndReturnCommandBuffer();
 }
 
 void OnscreenContextProvider::OnCommandBufferImplDestroyed() {
   DCHECK(command_buffer_impl_);
   command_buffer_impl_ = nullptr;
 }
 
 void OnscreenContextProvider::CreateAndReturnCommandBuffer() {
   mojo::CommandBufferPtr cb;
   command_buffer_impl_ = new gles2::CommandBufferImpl(
       GetProxy(&cb), pending_listener_.Pass(), state_->control_task_runner(),
       state_->sync_point_manager(),
       make_scoped_ptr(new gles2::CommandBufferDriver(
           widget_, state_->share_group(), state_->mailbox_manager(),
-          state_->sync_point_manager())));
+          state_->sync_point_manager(), requested_configuration_)));
   command_buffer_impl_->set_observer(this);
   pending_create_callback_.Run(cb.Pass());
   pending_create_callback_.reset();
 }
 
 }  // namespace mojo