Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1168983002: Fix graphics context test to pass in slimming paint. (Closed)

Created:
4 years, 10 months ago by wkorman
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix graphics context test to pass in slimming paint. BUG=497950 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196719

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bail out of RecordingCanvas test as it doesn't make sense in SP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M Source/platform/graphics/GraphicsContextTest.cpp View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
wkorman
4 years, 10 months ago (2015-06-08 23:24:15 UTC) #2
chrishtr
https://codereview.chromium.org/1168983002/diff/1/Source/platform/graphics/GraphicsContextTest.cpp File Source/platform/graphics/GraphicsContextTest.cpp (right): https://codereview.chromium.org/1168983002/diff/1/Source/platform/graphics/GraphicsContextTest.cpp#newcode270 Source/platform/graphics/GraphicsContextTest.cpp:270: if (!RuntimeEnabledFeatures::slimmingPaintEnabled()) { This test makes no sense in ...
4 years, 10 months ago (2015-06-08 23:34:58 UTC) #3
wkorman
https://codereview.chromium.org/1168983002/diff/1/Source/platform/graphics/GraphicsContextTest.cpp File Source/platform/graphics/GraphicsContextTest.cpp (right): https://codereview.chromium.org/1168983002/diff/1/Source/platform/graphics/GraphicsContextTest.cpp#newcode270 Source/platform/graphics/GraphicsContextTest.cpp:270: if (!RuntimeEnabledFeatures::slimmingPaintEnabled()) { On 2015/06/08 at 23:34:58, chrishtr wrote: ...
4 years, 10 months ago (2015-06-08 23:38:30 UTC) #4
chrishtr
lgtm
4 years, 10 months ago (2015-06-08 23:41:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168983002/20001
4 years, 10 months ago (2015-06-08 23:41:31 UTC) #7
Rik
? ? Hi, I'm currently on paternity leave. For urgent matters, please contact my manager. ...
4 years, 10 months ago (2015-06-08 23:41:36 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 00:46:28 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196719

Powered by Google App Engine
This is Rietveld 408576698