runtime/vm/parser_test.cc - Issue 1168933002: Fixes crashes in VM isolate shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser_test.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add asserts Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser_test.cc

diff --git a/runtime/vm/parser_test.cc b/runtime/vm/parser_test.cc

index e7450b7d2abb3ef7cc4b7a781598c9563fb25a39..823e613a2d3087c3ff20ad66e3c0b5c6b54b5491 100644

--- a/runtime/vm/parser_test.cc

+++ b/runtime/vm/parser_test.cc

@@ -204,6 +204,7 @@ char* SkipIndex(const char* input) {

static void SaveVars(Dart_IsolateId isolate_id,

intptr_t bp_id,

const Dart_CodeLocation& loc) {

+ ASSERT(Isolate::Current()->debugger() != NULL);

DebuggerStackTrace* stack =

Isolate::Current()->debugger()->StackTrace();

intptr_t num_frames = stack->Length();