runtime/vm/exceptions.cc - Issue 1168933002: Fixes crashes in VM isolate shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add asserts Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/exceptions.cc

diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc

index fa2e44179de9d83d7c11aceb4fa1899363a25afb..1a14466c5cd878afcd5f73cf8e060c102849e3b1 100644

--- a/runtime/vm/exceptions.cc

+++ b/runtime/vm/exceptions.cc

@@ -482,6 +482,7 @@ void Exceptions::Throw(Thread* thread, const Instance& exception) {

Isolate* isolate = thread->isolate();

if (exception.raw() != isolate->object_store()->out_of_memory() &&

exception.raw() != isolate->object_store()->stack_overflow()) {

+ ASSERT(isolate->debugger() != NULL);

isolate->debugger()->SignalExceptionThrown(exception);

}

// Null object is a valid exception object.