runtime/vm/debugger.cc - Issue 1168933002: Fixes crashes in VM isolate shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index 939dafdd8fdfab7866e6af741d3633fe4051c6e6..e2a02f116aca1b3e624bd095aa5d941f628bf644 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -1215,7 +1215,8 @@ void Debugger::Shutdown() {

delete bpt;

}

// Signal isolate shutdown event.

- if (!ServiceIsolate::IsServiceIsolateDescendant(isolate_)) {

+ if (!ServiceIsolate::IsServiceIsolateDescendant(isolate_) &&

+ (isolate_ != Dart::vm_isolate())) {

Cutch 2015/06/09 14:57:33 I think the real bug is that the vm-isolate should

zra 2015/06/09 15:45:17 Ah, yah. That makes sense. I'll see if I can get r

zra 2015/06/09 17:29:01 Done. Removed debugger from vm isolate, and added

SignalIsolateEvent(DebuggerEvent::kIsolateShutdown);

}

« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »