Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: runtime/vm/debugger.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger_api_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 } else { 310 } else {
311 InvokeEventHandler(&event); 311 InvokeEventHandler(&event);
312 } 312 }
313 } 313 }
314 } 314 }
315 315
316 316
317 void Debugger::SignalIsolateInterrupted() { 317 void Debugger::SignalIsolateInterrupted() {
318 if (HasEventHandler()) { 318 if (HasEventHandler()) {
319 Debugger* debugger = Isolate::Current()->debugger(); 319 Debugger* debugger = Isolate::Current()->debugger();
320 ASSERT(debugger != NULL);
321 debugger->SignalIsolateEvent(DebuggerEvent::kIsolateInterrupted); 320 debugger->SignalIsolateEvent(DebuggerEvent::kIsolateInterrupted);
322 } 321 }
323 } 322 }
324 323
325 324
326 // The vm service handles breakpoint notifications in a different way 325 // The vm service handles breakpoint notifications in a different way
327 // than the regular debugger breakpoint notifications. 326 // than the regular debugger breakpoint notifications.
328 static void SendServiceBreakpointEvent(ServiceEvent::EventType type, 327 static void SendServiceBreakpointEvent(ServiceEvent::EventType type,
329 Breakpoint* bpt) { 328 Breakpoint* bpt) {
330 if (Service::NeedsDebugEvents()) { 329 if (Service::NeedsDebugEvents()) {
(...skipping 2639 matching lines...) Expand 10 before | Expand all | Expand 10 after
2970 } 2969 }
2971 2970
2972 2971
2973 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) { 2972 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
2974 ASSERT(bpt->next() == NULL); 2973 ASSERT(bpt->next() == NULL);
2975 bpt->set_next(code_breakpoints_); 2974 bpt->set_next(code_breakpoints_);
2976 code_breakpoints_ = bpt; 2975 code_breakpoints_ = bpt;
2977 } 2976 }
2978 2977
2979 } // namespace dart 2978 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/debugger_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698