Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: runtime/vm/compiler.cc

Issue 1168933002: Fixes crashes in VM isolate shutdown. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Add asserts Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 1023 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 per_compile_timer.Stop(); 1034 per_compile_timer.Stop();
1035 1035
1036 if (FLAG_trace_compiler) { 1036 if (FLAG_trace_compiler) {
1037 ISL_Print("--> '%s' entry: %#" Px " size: %" Pd " time: %" Pd64 " us\n", 1037 ISL_Print("--> '%s' entry: %#" Px " size: %" Pd " time: %" Pd64 " us\n",
1038 function.ToFullyQualifiedCString(), 1038 function.ToFullyQualifiedCString(),
1039 Code::Handle(function.CurrentCode()).EntryPoint(), 1039 Code::Handle(function.CurrentCode()).EntryPoint(),
1040 Code::Handle(function.CurrentCode()).Size(), 1040 Code::Handle(function.CurrentCode()).Size(),
1041 per_compile_timer.TotalElapsedTime()); 1041 per_compile_timer.TotalElapsedTime());
1042 } 1042 }
1043 1043
1044 ASSERT(isolate->debugger() != NULL);
1044 isolate->debugger()->NotifyCompilation(function); 1045 isolate->debugger()->NotifyCompilation(function);
1045 1046
1046 if (FLAG_disassemble && FlowGraphPrinter::ShouldPrint(function)) { 1047 if (FLAG_disassemble && FlowGraphPrinter::ShouldPrint(function)) {
1047 DisassembleCode(function, optimized); 1048 DisassembleCode(function, optimized);
1048 } else if (FLAG_disassemble_optimized && 1049 } else if (FLAG_disassemble_optimized &&
1049 optimized && 1050 optimized &&
1050 FlowGraphPrinter::ShouldPrint(function)) { 1051 FlowGraphPrinter::ShouldPrint(function)) {
1051 // TODO(fschneider): Print unoptimized code along with the optimized code. 1052 // TODO(fschneider): Print unoptimized code along with the optimized code.
1052 ISL_Print("*** BEGIN CODE\n"); 1053 ISL_Print("*** BEGIN CODE\n");
1053 DisassembleCode(function, true); 1054 DisassembleCode(function, true);
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1329 const Object& result = 1330 const Object& result =
1330 PassiveObject::Handle(isolate->object_store()->sticky_error()); 1331 PassiveObject::Handle(isolate->object_store()->sticky_error());
1331 isolate->object_store()->clear_sticky_error(); 1332 isolate->object_store()->clear_sticky_error();
1332 return result.raw(); 1333 return result.raw();
1333 } 1334 }
1334 UNREACHABLE(); 1335 UNREACHABLE();
1335 return Object::null(); 1336 return Object::null();
1336 } 1337 }
1337 1338
1338 } // namespace dart 1339 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698