Use top frame's origin when checking content settings for plugins.

Use top frame's origin when checking content settings for plugins.

When creating plugins, the renderer currently sends an IPC to the
browser process and passes the top frame's URL, to be used in a
content settings check on the IO thread.  However, with out-of-process
iframes, this doesn't work if the top frame is a RemoteFrame, which
has no document or URL available.  This CL changes the content
settings check to use the top frame's origin instead, which will use
replicated origins for RemoteFrames.

For discussion about this change, see https://groups.google.com/a/chromium.org/d/topic/site-isolation-dev/JPKPFfZpVHE/discussion

BUG=426658, 466297
Committed: https://crrev.com/be8f323e5038b29399adcfa365603a9b7cd13574
Cr-Commit-Position: refs/heads/master@{#345104}

[alexmos, 2015-08-20 16:27:43]

alexmos@chromium.org changed reviewers:
+ nasko@chromium.org

[alexmos, 2015-08-20 16:27:44]

Nasko, can you please take a look?  This should fix our OOPIF plugin crashes. 
Trybots seem happy.  Interestingly, there used to be a test that was breaking
with this change (see https://crbug.com/426658#c9), but it doesn't appear to
exist anymore.

[nasko, 2015-08-20 20:44:24]

LGTM with a nit.

https://codereview.chromium.org/1168913002/diff/40001/chrome/browser/chrome_s...
File chrome/browser/chrome_site_per_process_browsertest.cc (right):

https://codereview.chromium.org/1168913002/diff/40001/chrome/browser/chrome_s...
chrome/browser/chrome_site_per_process_browsertest.cc:111: GURL frame_url =
embedded_test_server()->GetURL("b.com", "/object.html");
nit: flash_object.html, as object.html is a bit too generic and can be of other
types.

[alexmos, 2015-08-20 21:23:44]

https://codereview.chromium.org/1168913002/diff/40001/chrome/browser/chrome_s...
File chrome/browser/chrome_site_per_process_browsertest.cc (right):

https://codereview.chromium.org/1168913002/diff/40001/chrome/browser/chrome_s...
chrome/browser/chrome_site_per_process_browsertest.cc:111: GURL frame_url =
embedded_test_server()->GetURL("b.com", "/object.html");
On 2015/08/20 20:44:23, nasko wrote:
> nit: flash_object.html, as object.html is a bit too generic and can be of
other
> types.

Done.

[alexmos, 2015-08-20 21:26:34]

alexmos@chromium.org changed reviewers:
+ thestig@chromium.org

[alexmos, 2015-08-20 21:26:34]

thestig@: can you please review chrome/ for OWNERS?

[Lei Zhang, 2015-08-20 21:33:28]

lgtm

https://codereview.chromium.org/1168913002/diff/60001/chrome/renderer/plugins...
File chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc (right):

https://codereview.chromium.org/1168913002/diff/60001/chrome/renderer/plugins...
chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc:51:
render_frame->GetRoutingID(), GURL(orig_params.url), GURL(top_origin),
nit: Can you keep the old formatting if it fits in 80 columns? It's easier to
read. Ditto in chrome_plugin_placeholder.cc.

[alexmos, 2015-08-20 21:45:07]

https://codereview.chromium.org/1168913002/diff/60001/chrome/renderer/plugins...
File chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc (right):

https://codereview.chromium.org/1168913002/diff/60001/chrome/renderer/plugins...
chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc:51:
render_frame->GetRoutingID(), GURL(orig_params.url), GURL(top_origin),
On 2015/08/20 21:33:28, Lei Zhang wrote:
> nit: Can you keep the old formatting if it fits in 80 columns? It's easier to
> read. Ditto in chrome_plugin_placeholder.cc.

Done.

[Lei Zhang, 2015-08-20 21:48:17]

On 2015/08/20 21:45:07, alexmos wrote:
>
https://codereview.chromium.org/1168913002/diff/60001/chrome/renderer/plugins...
> File chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc (right):
> 
>
https://codereview.chromium.org/1168913002/diff/60001/chrome/renderer/plugins...
> chrome/renderer/plugins/shadow_dom_plugin_placeholder.cc:51:
> render_frame->GetRoutingID(), GURL(orig_params.url), GURL(top_origin),
> On 2015/08/20 21:33:28, Lei Zhang wrote:
> > nit: Can you keep the old formatting if it fits in 80 columns? It's easier
to
> > read. Ditto in chrome_plugin_placeholder.cc.
> 
> Done.

thanks!

[alexmos, 2015-08-24 16:30:55]

The CQ bit was checked by alexmos@chromium.org

[alexmos, 2015-08-24 16:30:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1168913002/#ps80001
(title: "Address thestig's nit")

[commit-bot: I haz the power, 2015-08-24 16:31:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168913002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1168913002/80001

[commit-bot: I haz the power, 2015-08-24 17:06:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-24 17:07:10]

Patchset 5 (id:??) landed as
https://crrev.com/be8f323e5038b29399adcfa365603a9b7cd13574
Cr-Commit-Position: refs/heads/master@{#345104}