Move PromoResourceService from Profile to BrowserProcessImpl/local_state().

chrome/browser/browser_process_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // When each service is created, we set a flag indicating this. At this point,
 // the service initialization could fail or succeed. This allows us to remember
 // if we tried to create a service, and not try creating it over and over if
 // the creation failed.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
 #define CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/debug/stack_trace.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/public/pref_change_registrar.h"
 #include "base/threading/non_thread_safe.h"
 #include "base/timer.h"
 #include "chrome/browser/browser_process.h"
 
 class ChromeNetLog;
 class ChromeResourceDispatcherHostDelegate;
 class CommandLine;
 class RemoteDebuggingServer;
 class PrefServiceSimple;
+class PromoResourceService;
 
 #if defined(ENABLE_PLUGIN_INSTALLATION)
 class PluginsResourceService;
 #endif
 
 namespace base {
 class SequencedTaskRunner;
 }
 
 namespace policy {
@@ skipping 232 matching lines @@
   scoped_ptr<chromeos::OomPriorityManager> oom_priority_manager_;
 #else
   scoped_ptr<ComponentUpdateService> component_updater_;
 
   scoped_refptr<CRLSetFetcher> crl_set_fetcher_;
 #endif
 
 #if defined(ENABLE_PLUGIN_INSTALLATION)
   scoped_refptr<PluginsResourceService> plugins_resource_service_;
 #endif
+  scoped_refptr<PromoResourceService> promo_resource_service_;

[jam, 2013/01/02 15:59:00]

nit: in general, it's more readable if all the non-ifdef'd members are listed
first, then all the ifdefs start. it looks like this is what this file was
adhering to as well. so move this up to before lie 261

[Dan Beam, 2013/01/02 22:27:51]

Done.

 
 #if defined(OS_WIN) && defined(USE_AURA)
   void PerformInitForWindowsAura(const CommandLine& command_line);
 
   // Hosts the channel for the Windows 8 metro viewer process which runs in
   // the ASH environment.
   scoped_ptr<MetroViewerProcessHost> metro_viewer_process_host_;
 #endif
 
   // TODO(eroman): Remove this when done debugging 113031. This tracks
   // the callstack which released the final module reference count.
   base::debug::StackTrace release_last_reference_callstack_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_