Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1168843003: Minor cleanup for WorkerThread::stop (Closed)

Created:
4 years, 10 months ago by kinuko
Modified:
4 years, 10 months ago
CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Minor cleanup for WorkerThread::stop Very lightweight, minor cleanups only. BUG=487050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196910

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M Source/core/workers/WorkerThread.h View 4 chunks +10 lines, -1 line 2 comments Download
M Source/core/workers/WorkerThread.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kinuko
PTL
4 years, 10 months ago (2015-06-10 05:45:55 UTC) #2
Takashi Toyoshima
lgtm
4 years, 10 months ago (2015-06-11 03:48:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168843003/1
4 years, 10 months ago (2015-06-11 04:17:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196910
4 years, 10 months ago (2015-06-11 04:21:29 UTC) #6
Noel Gordon
https://codereview.chromium.org/1168843003/diff/1/Source/core/workers/WorkerThread.h File Source/core/workers/WorkerThread.h (right): https://codereview.chromium.org/1168843003/diff/1/Source/core/workers/WorkerThread.h#newcode63 Source/core/workers/WorkerThread.h:63: // Called on the main thread. Is this true, ...
4 years, 10 months ago (2015-06-11 07:07:03 UTC) #8
kinuko
4 years, 10 months ago (2015-06-11 08:59:44 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1168843003/diff/1/Source/core/workers/WorkerT...
File Source/core/workers/WorkerThread.h (right):

https://codereview.chromium.org/1168843003/diff/1/Source/core/workers/WorkerT...
Source/core/workers/WorkerThread.h:63: // Called on the main thread.
On 2015/06/11 07:07:03, noel gordon wrote:
> Is this true, or is this an implicit statement of how our system currently
> works?  Also, can web workers start web workers?


It just states how our system works today. Currently nested worker is not
supported in blink/chromium.

Powered by Google App Engine
This is Rietveld 408576698