Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1168793003: Remove attempted bug mitigation in Mac typeface. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove attempted bug mitigation in Mac typeface. An attempt was made to hold onto the 'sbix' table when it existed when drawing to mitigate an issue with vanishing font data. This code has not affected the crash rate, so remove it. Committed: https://skia.googlesource.com/skia/+/1b5f25c5d75f4a992ce3eff1d12afa775f580954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168793003/1
5 years, 6 months ago (2015-06-08 19:34:06 UTC) #2
bungeman-skia
To offset the changes in https://codereview.chromium.org/1163573007/ , remove the old attempt at working around this ...
5 years, 6 months ago (2015-06-08 19:36:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-08 19:39:11 UTC) #6
bungeman-skia
Remove all the useless code!!!
5 years, 6 months ago (2015-06-08 20:34:07 UTC) #8
reed1
lgtm
5 years, 6 months ago (2015-06-08 21:17:25 UTC) #9
mtklein
lgtm
5 years, 6 months ago (2015-06-08 21:31:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168793003/1
5 years, 6 months ago (2015-06-08 21:31:39 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 21:32:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1b5f25c5d75f4a992ce3eff1d12afa775f580954

Powered by Google App Engine
This is Rietveld 408576698