Add an initial implementation of the Privacy Page. No subpages yet.

chrome/browser/extensions/api/settings_private/prefs_util.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/api/settings_private/prefs_util.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 27 matching lines @@
   s_whitelist = new PrefsUtil::TypedPrefMap();
   (*s_whitelist)["browser.show_home_button"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["bookmark_bar.show_on_all_tabs"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["download.default_directory"] =
       settings_private::PrefType::PREF_TYPE_STRING;
   (*s_whitelist)["download.prompt_for_download"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["homepage"] = settings_private::PrefType::PREF_TYPE_URL;
+  // Privacy

[James Hawkins, 2015/06/08 21:20:17]

Hmm. We don't currently have these broken up by section. If we're going to do
that, I think it's preferable to break up into methods.  Like
GetPrivacyKeys(&whitelist) or something.  What do you think?

[Jeremy Klein, 2015/06/09 03:42:15]

I'm worried about settings which may be in multiple pages... removed comment and
alphabetized.

+  (*s_whitelist)["alternate_error_pages.enabled"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["search.suggest_enabled"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["net.network_prediction_options"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["safebrowsing.extended_reporting_enabled"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["safebrowsing.enabled"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["spellcheck.use_spelling_service"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["enable_do_not_track"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
 
 #if defined(OS_CHROMEOS)
   (*s_whitelist)["cros.accounts.allowBWSI"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["cros.accounts.supervisedUsersEnabled"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["cros.accounts.showUserNamesOnSignIn"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["cros.accounts.allowGuest"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
@@ skipping 12 matching lines @@
   (*s_whitelist)["settings.a11y.screen_magnifier"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["settings.a11y.sticky_keys_enabled"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["settings.a11y.virtual_keyboard"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["settings.clock.use_24hour_clock"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
   (*s_whitelist)["settings.touchpad.enable_tap_dragging"] =
       settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["cros.metrics.reportingEnabled"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["cros.device.attestation_for_content_protection_enabled"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
+  (*s_whitelist)["settings.internet.wake_on_wifi_ssid"] =
+      settings_private::PrefType::PREF_TYPE_BOOLEAN;
 #endif
 
   return *s_whitelist;
 }
 
 api::settings_private::PrefType PrefsUtil::GetType(const std::string& name,
                                                    base::Value::Type type) {
   switch (type) {
     case base::Value::Type::TYPE_BOOLEAN:
       return api::settings_private::PrefType::PREF_TYPE_BOOLEAN;
@@ skipping 236 matching lines @@
 
 bool PrefsUtil::IsCrosSetting(const std::string& pref_name) {
 #if defined(OS_CHROMEOS)
   return CrosSettings::Get()->IsCrosSettings(pref_name);
 #else
   return false;
 #endif
 }
 
 }  // namespace extensions