webrtc/common_audio/lapped_transform_unittest.cc - Issue 1168753002: Match existing type usage better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_audio/lapped_transform_unittest.cc

Issue 1168753002: Match existing type usage better. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Attempted test fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_audio/lapped_transform_unittest.cc

diff --git a/webrtc/common_audio/lapped_transform_unittest.cc b/webrtc/common_audio/lapped_transform_unittest.cc

index c30651c9a30af1e02b902b00cb6044fbe037e14c..3becfe1381b91a1dbd9c5969c1c60ba5b6592eb6 100644

--- a/webrtc/common_audio/lapped_transform_unittest.cc

+++ b/webrtc/common_audio/lapped_transform_unittest.cc

@@ -51,11 +51,12 @@ class FftCheckerCallback : public webrtc::LappedTransform::Callback {

complex<float>* const* out_block) {

CHECK_EQ(in_channels, out_channels);

- float full_length = (frames - 1) * 2;

+ int full_length = (frames - 1) * 2;

++block_num_;

if (block_num_ > 0) {

- ASSERT_NEAR(in_block[0][0].real(), full_length, 1e-5f);

+ ASSERT_NEAR(in_block[0][0].real(), static_cast<float>(full_length),

+ 1e-5f);

ASSERT_NEAR(in_block[0][0].imag(), 0.0f, 1e-5f);

for (int i = 1; i < frames; ++i) {

ASSERT_NEAR(in_block[0][i].real(), 0.0f, 1e-5f);