talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc - Issue 1168753002: Match existing type usage better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc

Issue 1168753002: Match existing type usage better. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Attempted test fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc

diff --git a/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc b/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc

index 8fcbfd701237198262449d42fe5b6caf2bd58750..821b44caa4f42b4367ff4d95e1473d19a74f8238 100644

--- a/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc

+++ b/talk/app/webrtc/test/fakeaudiocapturemodule_unittest.cc

@@ -66,7 +66,7 @@ class FakeAdmTest : public testing::Test,

const bool keyPressed,

uint32_t& newMicLevel) {

rec_buffer_bytes_ = nSamples * nBytesPerSample;

- if ((rec_buffer_bytes_ <= 0) ||

+ if ((rec_buffer_bytes_ == 0) ||

(rec_buffer_bytes_ > FakeAudioCaptureModule::kNumberSamples *

FakeAudioCaptureModule::kNumberBytesPerSample)) {

ADD_FAILURE();