Match existing type usage better.

webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 80 matching lines @@
   double rateUB = 0;
 #endif
   FILE* histFile;
   FILE* averageFile;
   int sampFreqKHz;
   int samplesIn10Ms;
   int16_t maxStreamLen = 0;
   char histFileName[500];
   char averageFileName[500];
   unsigned int hist[600];
-  unsigned int tmpSumStreamLen = 0;
+  double tmpSumStreamLen = 0;

[kwiberg-webrtc, 2015/06/08 13:09:38]

0.0 when you assign to a double, for clarity?

[Peter Kasting, 2015/06/08 20:44:29]

I can if you really want, though I'm not a big fan.

As you sort of allude to below, "= 0" is fairly common throughout our codebase
-- "= 0.0" is exceptional.  And "= 0.0" implies to me that it was important not
to say "= 0", which is what I'd have normally expected the code to read; like,
maybe somehow "= 0" would result in a run-time value conversion of int to
double, or "0" alone wasn't precise enough.  Since neither is true, it calls my
eye to the code for a difference that doesn't actually matter.

ALl that said, my opposition to this is weak, so if you still think 0.0 is
better, I'll do that.

[kwiberg-webrtc, 2015/06/09 00:48:12]

The WebRTC audio code is littered with float literals such as 0.f, but if that's
not the case in general then I'm happy to use just 0 here (since, as you say,
the compiler will not care either way---the only consideration is human
readability).

[Peter Kasting, 2015/06/10 01:09:54]

Acknowledged.

   unsigned int packetCntr = 0;
   unsigned int lostPacketCntr = 0;
   uint8_t payload[1200];
   uint8_t payloadRCU[1200];
   uint16_t packetLossPercent = 0;
   int16_t rcuStreamLen = 0;
   int onlyEncode;
   int onlyDecode;
 
   BottleNeckModel packetData;
@@ skipping 267 matching lines @@
 
     maxStreamLen = (stream_len > maxStreamLen) ? stream_len : maxStreamLen;
     packetCntr++;
 
     hist[stream_len]++;
     if (averageFile != NULL) {
       tmpSumStreamLen += stream_len;
       if (packetCntr == 100) {
         // kbps
         fprintf(averageFile, "%8.3f ",
-                (double)tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
+                tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
         packetCntr = 0;
         tmpSumStreamLen = 0;

[kwiberg-webrtc, 2015/06/08 13:09:38]

0.0 here too? (And in any more places?)

       }
     }
 
     if (onlyEncode) {
       uint8_t auxUW8;
       auxUW8 = (uint8_t)(((stream_len & 0x7F00) >> 8) & 0xFF);
       if (fwrite(&auxUW8, sizeof(uint8_t), 1, outp) != 1) {
         return -1;
       }
 
@@ skipping 97 matching lines @@
     int n;
     for (n = 0; n < 600; n++) {
       fprintf(histFile, "%6d ", hist[n]);
     }
     fprintf(histFile, "\n");
     fclose(histFile);
   }
   if (averageFile != NULL) {
     if (packetCntr > 0) {
       fprintf(averageFile, "%8.3f ",
-              (double)tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
+              tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
     }
     fprintf(averageFile, "\n");
     fclose(averageFile);
   }
 
   fclose(inp);
   fclose(outp);
 
   WebRtcIsac_Free(ISAC_main_inst);
 
@@ skipping 55 matching lines @@
   str->lastArrivalTime = 0;
 
   str->maxPayloadLB = 0;
   str->maxPayloadUB = 0;
   str->lbBytes = 0;
   str->ubBytes = 0;
 
   return 0;
 };
 #endif