Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1168743003: Fix the GN upload (build) flags to not depend on GN. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the GN upload (build) flags to not depend on GN. This changes the GN args we use on the linux_chromium_gn_upload bot to not require a runtime dependency on GN. This CL also deletes the old ntries for the 32-bit and 64-bit upload bots (we just do 64-bit now, using the newer builder named linux_chromium_gn_upload). TBR=brettw@chromium.org BUG= Committed: https://crrev.com/5a47c761a09130cd75332b443c92f7e312070b26 Cr-Commit-Position: refs/heads/master@{#333140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-05 20:22:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168743003/1
5 years, 6 months ago (2015-06-05 20:24:24 UTC) #3
brettw
lgtm
5 years, 6 months ago (2015-06-05 20:30:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 21:39:54 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 21:40:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a47c761a09130cd75332b443c92f7e312070b26
Cr-Commit-Position: refs/heads/master@{#333140}

Powered by Google App Engine
This is Rietveld 408576698