Refactor how we handle BRs with clearance

Refactor how we handle BRs with clearance

This is a follow-up to https://codereview.chromium.org/1156063002 and 
https://blink.lc/blink/commit/?id=712375bd4009d756b411cb80164fa1ed04ee219a.

In the latter CL we realized we need to give up on syncing with clean lines if we
have floats and a <br> with clearance. That decision should really be made in
determineEndPosition using the same criteria introduced in the former CL.

BUG=496339
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197768

[rhogan, 2015-06-18 18:44:03]

robhogan@gmail.com changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-06-22 18:22:43]

This looks good. Just one question I'd like answered before the final stamp.

https://codereview.chromium.org/1168733002/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1168733002/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutBlockFlowLine.cpp:1754: InlineBox* lastBox =
style()->isLeftToRightDirection() ? curr->lastLeafChild() :
curr->firstLeafChild();
I understand you're moving this code around. If we end with a break, won't the
lineBreakObj() on RootInlineBox point to that without having to drill down and
look for the first/last leaf child?

[rhogan, 2015-06-22 20:27:16]

https://codereview.chromium.org/1168733002/diff/20001/Source/core/layout/Layo...
File Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1168733002/diff/20001/Source/core/layout/Layo...
Source/core/layout/LayoutBlockFlowLine.cpp:1754: InlineBox* lastBox =
style()->isLeftToRightDirection() ? curr->lastLeafChild() :
curr->firstLeafChild();
On 2015/06/22 at 18:22:42, leviw wrote:
> I understand you're moving this code around. If we end with a break, won't the
lineBreakObj() on RootInlineBox point to that without having to drill down and
look for the first/last leaf child?
Had to look it up: lineBreakObj() is the object *after* the line break. <br>'s
don't result in lineBreakObj() getting set with the br object, it would only get
one if there was another br object after it. 

Ah, line layout.

[leviw_travelin_and_unemployed, 2015-06-22 21:36:00]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-06-22 21:36:00]

lgtm

*sigh*

Thanks :p

[commit-bot: I haz the power, 2015-06-22 21:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168733002/20001

[commit-bot: I haz the power, 2015-06-22 23:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 23:03:07]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60178)

[rhogan, 2015-06-24 17:50:55]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2015-06-24 17:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168733002/20001

[commit-bot: I haz the power, 2015-06-24 19:02:10]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197768