Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 116873002: Add more formatting options for my_activity.py (Closed)

Created:
7 years ago by jsbell
Modified:
6 years, 11 months ago
Reviewers:
deymo, cmp, Vadim Sh., szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add more formatting options for my_activity.py Support --output-format-heading for the headings ('Issues:', etc), and a simple --markdown flag that sets item and heading formats to something markdown friendly. R=deymo@chromium.org, szager@chromium.org, deymo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243204

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M my_activity.py View 1 6 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
deymo@ - please take a look?
7 years ago (2013-12-17 00:09:30 UTC) #1
deymo
I like it! You will probably need OWNER lgtm from someone. I guess cmp@ could ...
7 years ago (2013-12-17 01:38:15 UTC) #2
jsbell
deymo@ - thanks! cmp@ - can you please take a look? https://codereview.chromium.org/116873002/diff/1/my_activity.py File my_activity.py (right): ...
7 years ago (2013-12-17 18:59:54 UTC) #3
cmp
Adding vadimsh, szager who should take a look to review this.
7 years ago (2013-12-18 17:58:33 UTC) #4
szager1
lgtm
7 years ago (2013-12-18 18:25:51 UTC) #5
jsbell
6 years, 11 months ago (2014-01-06 23:49:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r243204.

Powered by Google App Engine
This is Rietveld 408576698