Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1168723002: Add TypedArray constructors with SharedArrayBuffer to the external API. (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add TypedArray constructors with SharedArrayBuffer to the external API. BUG=chromium:497295 LOG=n Committed: https://crrev.com/f145765524b11b6ce5d23bfa94180002a77fcc9d Cr-Commit-Position: refs/heads/master@{#28850}

Patch Set 1 #

Patch Set 2 : check flag #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -38 lines) Patch
M include/v8.h View 11 chunks +22 lines, -0 lines 0 comments Download
M src/api.cc View 1 2 4 chunks +56 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +114 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
5 years, 6 months ago (2015-06-05 16:59:48 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-08 09:31:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168723002/40001
5 years, 6 months ago (2015-06-08 17:14:23 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-08 18:24:22 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 18:24:32 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f145765524b11b6ce5d23bfa94180002a77fcc9d
Cr-Commit-Position: refs/heads/master@{#28850}

Powered by Google App Engine
This is Rietveld 408576698