Add support for korean-hangul-formal list style type

Add support for korean-hangul-formal list style type

In order to support this make toCJKIdeographic aware of the exact
language being used because they have different behaviors [1].
This makes it also easier to add more cjk types in the future.

For tests import relevant ones from csswg-test github repo and
change them to use the dump-list.js framework.

Behavior matches Firefox.

[1] http://www.w3.org/TR/2013/WD-css-counter-styles-3-20130718/#extended-cjk

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197049

[rwlbuis, 2015-06-08 18:37:28]

rob.buis@samsung.com changed reviewers:
+ leviw@chromium.org, tabatkins@chromium.org

[rwlbuis, 2015-06-08 18:37:30]

PTAL. Should be pretty easy after this to add more cjk types.

[leviw_travelin_and_unemployed, 2015-06-08 20:02:23]

On 2015/06/08 at 18:37:30, rob.buis wrote:
> PTAL. Should be pretty easy after this to add more cjk types.

The bug linked is for "[W3C] css3-images draft supports" which I don't think is
what you want.

[rwlbuis, 2015-06-08 20:33:29]

On 2015/06/08 20:02:23, leviw wrote:
> On 2015/06/08 at 18:37:30, rob.buis wrote:
> > PTAL. Should be pretty easy after this to add more cjk types.
> 
> The bug linked is for "[W3C] css3-images draft supports" which I don't think
is
> what you want.

Ah, right, I was confused because it mentioned "list-style", but now I see it
refers to the image part only. Since I can't find any other bug for this I'll
just remove the entry.

[rwlbuis, 2015-06-11 15:30:11]

On 2015/06/08 20:33:29, rwlbuis wrote:
> On 2015/06/08 20:02:23, leviw wrote:
> > On 2015/06/08 at 18:37:30, rob.buis wrote:
> > > PTAL. Should be pretty easy after this to add more cjk types.
> > 
> > The bug linked is for "[W3C] css3-images draft supports" which I don't think
> is
> > what you want.
> 
> Ah, right, I was confused because it mentioned "list-style", but now I see it
> refers to the image part only. Since I can't find any other bug for this I'll
> just remove the entry.

Note that the patch also adds negative value handling for cjk-ideographic (kind
of hard to avoid as the algorithm and datastructures are shared). I could add
more tests from the spec like fast/lists/css3-counter-styles-05?.html but for
cjk-ideographic if needed.

PTAL.

[leviw_travelin_and_unemployed, 2015-06-11 20:25:30]

leviw@chromium.org changed reviewers:
+ eae@chromium.org, esprehn@chromium.org

[leviw_travelin_and_unemployed, 2015-06-11 20:25:31]

This looks like it should be reviewed by someone with an E as the *first* letter
of their name, not the second. Adding some possible candidates.

[eae, 2015-06-11 20:41:43]

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
File LayoutTests/fast/lists/css3-counter-styles-052.html (right):

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
LayoutTests/fast/lists/css3-counter-styles-052.html:5:
<title>korean-hangul-formal, 0-9</title>
Use single or double quotes consistently. We generally use double quotes for
HTML.

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
LayoutTests/fast/lists/css3-counter-styles-052.html:26: window.onload = runTest;
Do you really need to wait for the onload event? Why not move the script block
to be at the end of the body and then just call runTest() directly instead?
Should be faster and require less code.

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
LayoutTests/fast/lists/css3-counter-styles-052.html:47: You will need an
appropriate font to run this test.
This note is only relevant to those viewing the test in a browser, having it as
a comment all but grantees that the only people that would benefit from it will
never see it. Either remove it or make it a paragraph.

https://codereview.chromium.org/1168643003/diff/120001/Source/core/layout/Lay...
File Source/core/layout/LayoutListMarker.cpp (right):

https://codereview.chromium.org/1168643003/diff/120001/Source/core/layout/Lay...
Source/core/layout/LayoutListMarker.cpp:396: UChar characters[bufferLength + 5];
// add room for negative symbols (max is 5).
Use const for magic number.

const maxLengthForNegativeSymbols = 5;
UChar characters[bufferLength + maxLengthForNegativeSymbols];

https://codereview.chromium.org/1168643003/diff/120001/Source/core/layout/Lay...
Source/core/layout/LayoutListMarker.cpp:398: // Handle negative
Redundant comment, please remove.

[rwlbuis, 2015-06-11 22:20:16]

PTAL :)

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
File LayoutTests/fast/lists/css3-counter-styles-052.html (right):

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
LayoutTests/fast/lists/css3-counter-styles-052.html:5:
<title>korean-hangul-formal, 0-9</title>
On 2015/06/11 20:41:43, eae wrote:
> Use single or double quotes consistently. We generally use double quotes for
> HTML.

Done. BTW my thinking was keeping the w3c tests as much as possible as-is.

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
LayoutTests/fast/lists/css3-counter-styles-052.html:26: window.onload = runTest;
On 2015/06/11 20:41:43, eae wrote:
> Do you really need to wait for the onload event? Why not move the script block
> to be at the end of the body and then just call runTest() directly instead?
> Should be faster and require less code.

Good point, fixed.

https://codereview.chromium.org/1168643003/diff/120001/LayoutTests/fast/lists...
LayoutTests/fast/lists/css3-counter-styles-052.html:47: You will need an
appropriate font to run this test.
On 2015/06/11 20:41:43, eae wrote:
> This note is only relevant to those viewing the test in a browser, having it
as
> a comment all but grantees that the only people that would benefit from it
will
> never see it. Either remove it or make it a paragraph.

Done.

https://codereview.chromium.org/1168643003/diff/120001/Source/core/layout/Lay...
File Source/core/layout/LayoutListMarker.cpp (right):

https://codereview.chromium.org/1168643003/diff/120001/Source/core/layout/Lay...
Source/core/layout/LayoutListMarker.cpp:396: UChar characters[bufferLength + 5];
// add room for negative symbols (max is 5).
On 2015/06/11 20:41:43, eae wrote:
> Use const for magic number.
> 
> const maxLengthForNegativeSymbols = 5;
> UChar characters[bufferLength + maxLengthForNegativeSymbols];

Done.

https://codereview.chromium.org/1168643003/diff/120001/Source/core/layout/Lay...
Source/core/layout/LayoutListMarker.cpp:398: // Handle negative
On 2015/06/11 20:41:43, eae wrote:
> Redundant comment, please remove.

Done.

[rwlbuis, 2015-06-11 22:20:16]

PTAL :)

[eae, 2015-06-11 22:21:25]

LGTM

[rwlbuis, 2015-06-11 22:38:49]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-06-11 22:39:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168643003/140001

[commit-bot: I haz the power, 2015-06-12 01:48:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 01:48:40]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66330)

[rwlbuis, 2015-06-12 01:54:12]

On 2015/06/12 01:48:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_blink_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66330)

Ouch, looks like I forgot to update the table param to the correct size, will
fix tomorrow.

[rwlbuis, 2015-06-12 12:48:42]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-06-12 12:48:43]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1168643003/#ps160001
(title: "Fix table param")

[commit-bot: I haz the power, 2015-06-12 12:48:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168643003/160001

[commit-bot: I haz the power, 2015-06-12 15:14:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 15:14:21]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66428)

[rwlbuis, 2015-06-12 16:07:52]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-06-12 16:07:52]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1168643003/#ps180001
(title: "Actually add a 0 value for the neg fields")

[commit-bot: I haz the power, 2015-06-12 16:08:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168643003/180001

[commit-bot: I haz the power, 2015-06-12 17:45:09]

Committed patchset #10 (id:180001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197049