Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc

Issue 116863003: gpu: Reuse transfer buffers more aggresively (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Async upload token part of existing Async command; use separate shared memory to sync async upload … Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc
diff --git a/gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc b/gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc
index dcd870ddd0c730cd05daf4296faa317f7d4f1083..2fa4fb5c7cc0c0889bf8be3b88a21f2f241f8129 100644
--- a/gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc
+++ b/gpu/command_buffer/service/async_pixel_transfer_manager_idle.cc
@@ -288,6 +288,12 @@ void AsyncPixelTransferManagerIdle::BindCompletedAsyncTransfers() {
// Everything is already bound.
}
+void AsyncPixelTransferManagerIdle::AsyncRun(const base::Closure& callback) {
+ shared_state_.tasks.push_back(
+ Task(0, // 0 transfer_id for notification tasks.
+ base::Bind(callback)));
+}
+
void AsyncPixelTransferManagerIdle::AsyncNotifyCompletion(
const AsyncMemoryParams& mem_params,
AsyncPixelTransferCompletionObserver* observer) {
@@ -296,15 +302,14 @@ void AsyncPixelTransferManagerIdle::AsyncNotifyCompletion(
return;
}
- shared_state_.tasks.push_back(
- Task(0, // 0 transfer_id for notification tasks.
- base::Bind(
- &PerformNotifyCompletion,
- mem_params,
- base::Owned(new ScopedSafeSharedMemory(safe_shared_memory_pool(),
- mem_params.shared_memory,
- mem_params.shm_size)),
- make_scoped_refptr(observer))));
+ AsyncRun(
+ base::Bind(
+ &PerformNotifyCompletion,
+ mem_params,
+ base::Owned(new ScopedSafeSharedMemory(safe_shared_memory_pool(),
+ mem_params.shared_memory,
+ mem_params.shm_size)),
+ make_scoped_refptr(observer)));
}
uint32 AsyncPixelTransferManagerIdle::GetTextureUploadCount() {

Powered by Google App Engine
This is Rietveld 408576698