Add feedback uploader to upload reports in a sequenced manner with retries.

chrome/browser/feedback/feedback_uploader_delegate.cc

Index: chrome/browser/feedback/feedback_uploader_delegate.cc
diff --git a/chrome/browser/feedback/feedback_uploader_delegate.cc b/chrome/browser/feedback/feedback_uploader_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..93cb7bf0584762d27ed455c6ca5211cd53b846b8
--- /dev/null
+++ b/chrome/browser/feedback/feedback_uploader_delegate.cc
@@ -0,0 +1,65 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/feedback/feedback_uploader_delegate.h"
+
+#include <sstream>
+
+#include "base/logging.h"
+#include "net/url_request/url_fetcher.h"
+#include "url/gurl.h"
+
+namespace feedback {
+namespace {
+
+const int kHttpPostSuccessNoContent = 204;
+const int kHttpPostFailNoConnection = -1;
+const int kHttpPostFailClientError = 400;
+const int kHttpPostFailServerError = 500;
+
+}  // namespace
+
+FeedbackUploaderDelegate::FeedbackUploaderDelegate(
+    scoped_ptr<std::string> post_body,
+    const base::Closure& success_callback,
+    const ReportDataCallback& error_callback)
+        : post_body_(post_body.Pass()),
+          success_callback_(success_callback),
+          error_callback_(error_callback) {
+}
+
+FeedbackUploaderDelegate::~FeedbackUploaderDelegate() {}
+
+void FeedbackUploaderDelegate::OnURLFetchComplete(
+    const net::URLFetcher* source) {
+  std::stringstream error_stream;
+  int response_code = source->GetResponseCode();
+  if (response_code == kHttpPostSuccessNoContent) {
+    error_stream << "Success";
+    success_callback_.Run();
+  } else {
+    // Process the error for debug output
+    if (response_code == kHttpPostFailNoConnection) {
+      error_stream << "No connection to server.";
+    } else if ((response_code > kHttpPostFailClientError) &&
+               (response_code < kHttpPostFailServerError)) {
+      error_stream << "Client error: HTTP response code " << response_code;
+    } else if (response_code > kHttpPostFailServerError) {
+      error_stream << "Server error: HTTP response code " << response_code;
+    } else {
+      error_stream << "Unknown error: HTTP response code " << response_code;
+    }
+    error_callback_.Run(post_body_.Pass());
+  }
+
+  LOG(WARNING) << "FEEDBACK: Submission to feedback server ("
+               << source->GetURL() << ") status: " << error_stream.str();
+
+  // Delete the URLFetcher.
+  delete source;

[Zachary Kuznia, 2013/12/17 01:12:57]

If you put this in a scoped_ptr at the beginning of the function, you can
protect against a memory leak if an early return gets added later.

[rkc, 2013/12/17 23:26:00]

Done.

+  // And then delete ourselves.
+  delete this;
+}
+
+}  // namespace feedback