Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1168613004: Remove some old fun related to the old multicol implementation. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-06-04 16:12:23 UTC) #1
dsinclair
https://codereview.chromium.org/1168613004/diff/1/Source/core/layout/LayoutBlock.cpp File Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1168613004/diff/1/Source/core/layout/LayoutBlock.cpp#newcode1136 Source/core/layout/LayoutBlock.cpp:1136: bool inlineChildrenBlockHasLayer = inlineChildrenBlock->hasLayer(); Do we still need this ...
5 years, 6 months ago (2015-06-04 16:35:59 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1168613004/diff/1/Source/core/layout/LayoutBlock.cpp File Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/1168613004/diff/1/Source/core/layout/LayoutBlock.cpp#newcode1136 Source/core/layout/LayoutBlock.cpp:1136: bool inlineChildrenBlockHasLayer = inlineChildrenBlock->hasLayer(); On 2015/06/04 16:35:57, dsinclair wrote: ...
5 years, 6 months ago (2015-06-04 16:43:40 UTC) #3
dsinclair
lgtm
5 years, 6 months ago (2015-06-04 16:44:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168613004/1
5 years, 6 months ago (2015-06-04 16:44:58 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 16:50:32 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196512

Powered by Google App Engine
This is Rietveld 408576698