Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1168553003: Suppress dumping number of unload handlers when LayoutTest ends (Closed)

Created:
5 years, 6 months ago by kouhei (in TOK)
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress dumping number of unload handlers when LayoutTest ends Before this CL, content shell (in DRT mode) dumped number of onunload handlers when test end. This feature was added 5 years ago in WebKit for undisclosed Safari bug: https://blink.lc/blink/commit/?id=4463bfd9a3882721f2252d3b380d60213a66dd37 This unload handler count dump isn't useful in current Blink, and it is also leading to flakiness of LayoutTests results after Blink Scheduler / Threaded Data Parser changes, as they are not deterministic if onunload handler on iframe is registered before/after its navigation. This CL removes this feature, and should unblock "Threaded Parser Data Receiver" implementation in Blink. BUG=277124 Committed: https://crrev.com/0a2aaff2a36dbb2634af9eaeeb3cd44d6be77e95 Cr-Commit-Position: refs/heads/master@{#332588}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M components/test_runner/web_test_proxy.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
kouhei (in TOK)
5 years, 6 months ago (2015-06-03 05:12:12 UTC) #2
kouhei (in TOK)
tkent: Do you have any thoughts on this change? I'd like to chat about how ...
5 years, 6 months ago (2015-06-03 05:13:50 UTC) #3
tkent
On 2015/06/03 05:13:50, kouhei wrote: > tkent: Do you have any thoughts on this change? ...
5 years, 6 months ago (2015-06-03 05:49:12 UTC) #4
kouhei (in TOK)
On 2015/06/03 05:49:12, tkent wrote: > On 2015/06/03 05:13:50, kouhei wrote: > > tkent: Do ...
5 years, 6 months ago (2015-06-03 05:50:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168553003/1
5 years, 6 months ago (2015-06-03 10:02:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/67904) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-03 10:09:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168553003/20001
5 years, 6 months ago (2015-06-03 10:36:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 11:10:19 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:11:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a2aaff2a36dbb2634af9eaeeb3cd44d6be77e95
Cr-Commit-Position: refs/heads/master@{#332588}

Powered by Google App Engine
This is Rietveld 408576698