Use report_fatal_error before destroying input object on error.

src/PNaClTranslator.cpp

 //===- subzero/src/PNaClTranslator.cpp - ICE from bitcode -----------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the PNaCl bitcode file to Ice, to machine code
@@ skipping 2967 matching lines @@
 void PNaClTranslator::translateBuffer(const std::string &IRFilename,
                                       MemoryBuffer *MemBuf) {
   std::unique_ptr<MemoryObject> MemObj(getNonStreamedMemoryObject(
       reinterpret_cast<const unsigned char *>(MemBuf->getBufferStart()),
       reinterpret_cast<const unsigned char *>(MemBuf->getBufferEnd())));
   translate(IRFilename, std::move(MemObj));
 }
 
 void PNaClTranslator::translate(const std::string &IRFilename,
                                 std::unique_ptr<MemoryObject> &&MemObj) {
-
+  // On error, we report_fatal_error to avoid destroying the MemObj.
+  // That may still be in use by IceBrowserCompileServer. Otherwise,
+  // we need to change the MemObj to be ref-counted, or have a wrapper,
+  // or simply leak. We also need a hook to tell the IceBrowserCompileServer
+  // to unblock its QueueStreamer.
+  // https://code.google.com/p/nativeclient/issues/detail?id=4163
+  Ostream &ErrStream = getContext()->getStrError();
   // Read header and verify it is good.
   NaClBitcodeHeader Header;
   if (Header.Read(MemObj.get())) {
-    errs() << "Invalid PNaCl bitcode header.\n";
-    ErrorStatus.assign(EC_Bitcode);
-    return;
+    llvm::report_fatal_error("Invalid PNaCl bitcode header");
   }
   if (!Header.IsSupported()) {
-    errs() << Header.Unsupported();
+    ErrStream << Header.Unsupported();
     if (!Header.IsReadable()) {
-      errs() << "Invalid PNaCl bitcode header.\n";
-      ErrorStatus.assign(EC_Bitcode);
-      return;
+      llvm::report_fatal_error("Invalid PNaCl bitcode header");
     }
   }
 
   // Create a bitstream reader to read the bitcode file.
   NaClBitstreamReader InputStreamFile(MemObj.release(), Header);
   NaClBitstreamCursor InputStream(InputStreamFile);
 
   TopLevelParser Parser(*this, InputStream, ErrorStatus);
   int TopLevelBlocks = 0;
   while (!InputStream.AtEndOfStream()) {
     if (Parser.Parse()) {
       ErrorStatus.assign(EC_Bitcode);
       return;
     }
     ++TopLevelBlocks;
   }
 
   if (TopLevelBlocks != 1) {
-    errs() << IRFilename
-           << ": Contains more than one module. Found: " << TopLevelBlocks
-           << "\n";
-    ErrorStatus.assign(EC_Bitcode);
+    ErrStream << IRFilename
+              << ": Contains more than one module. Found: " << TopLevelBlocks
+              << "\n";
+    llvm::report_fatal_error("Bitcode has more than one module");
   }
   if (InputStreamFile.getBitcodeBytes().getExtent() % 4 != 0) {
-    errs() << IRFilename
-           << ": Bitcode stream should be a multiple of 4 bytes in length.\n";
-    ErrorStatus.assign(EC_Bitcode);
-    return;
+    ErrStream
+        << IRFilename
+        << ": Bitcode stream should be a multiple of 4 bytes in length.\n";
+    llvm::report_fatal_error("Bitcode stream should be a multiple of 4 bytes");
   }
 }
 
 } // end of namespace Ice