[Sync] Improve Android typed URL tests.

[Sync] Improve Android typed URL tests.

- Split the tests into their own file.
- Add the deleted on server case.
- Factor out many common subroutines.

BUG=480604
Committed: https://crrev.com/40a831ce2465a43685747808531f255963c13f3f
Cr-Commit-Position: refs/heads/master@{#333079}

[maxbogue, 2015-06-02 20:32:48]

maxbogue@chromium.org changed reviewers:
+ pvalenzuela@chromium.org, zea@chromium.org

[maxbogue, 2015-06-02 20:32:49]

Hey Nicolas and Patrick, please review this change as well. You should see an
awful lot of parallels with http://crrev.com/1156573006.

[Nicolas Zea, 2015-06-03 17:36:35]

Leaving this review for Patrick

[pval...(no longer on Chromium), 2015-06-04 18:28:29]

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java
(right):

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java:54:
setupTestAccountAndSignInToSync(CLIENT_ID);
Do we think most/all future typed URL tests will want to sign in as their first
step?

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java:100:
private void loadTypedUrl(final String url) {
I'm not entirely sold on this name. I know what it does (loads a URL in the
browser as if a user had typed it, thus making it what we call a typed URL), but
it makes me think of loading the URL from memory/database or something like
that.

Any ideas or thoughts for alternatives? The best I can think of right now
loadUrlByTyping().

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java:110:
private void addServerTypedUrlAndSync(String url) throws InterruptedException {
what do you think about keeping the Sync-triggering call in a separate method?
"And" in the method name can sometimes be a sign that the method is doing two
unrelated things (I think that's true here).

[maxbogue, 2015-06-04 22:24:37]

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java
(right):

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java:54:
setupTestAccountAndSignInToSync(CLIENT_ID);
On 2015/06/04 18:28:29, pvalenzuela wrote:
> Do we think most/all future typed URL tests will want to sign in as their
first
> step?

Yes.

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java:100:
private void loadTypedUrl(final String url) {
On 2015/06/04 18:28:29, pvalenzuela wrote:
> I'm not entirely sold on this name. I know what it does (loads a URL in the
> browser as if a user had typed it, thus making it what we call a typed URL),
but
> it makes me think of loading the URL from memory/database or something like
> that.
> 
> Any ideas or thoughts for alternatives? The best I can think of right now
> loadUrlByTyping().

loadUrlByTyping works for me. ChromeShellTestBase defines loadUrl(), which is
the same thing but without the typed transition, so I was basing the name off
that.

https://codereview.chromium.org/1168533002/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java:110:
private void addServerTypedUrlAndSync(String url) throws InterruptedException {
On 2015/06/04 18:28:29, pvalenzuela wrote:
> what do you think about keeping the Sync-triggering call in a separate method?
> "And" in the method name can sometimes be a sign that the method is doing two
> unrelated things (I think that's true here).

Done. I'd considered this when writing it but didn't feel strongly either way.

[pval...(no longer on Chromium), 2015-06-05 17:06:29]

lgtm

make it so

[maxbogue, 2015-06-05 17:07:25]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:08:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168533002/20001

[commit-bot: I haz the power, 2015-06-05 17:11:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-05 17:12:33]

Patchset 2 (id:??) landed as
https://crrev.com/40a831ce2465a43685747808531f255963c13f3f
Cr-Commit-Position: refs/heads/master@{#333079}