Issue 1168523004: Revert of Added CGFloat comparison functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1168523004: Revert of Added CGFloat comparison functions. (Closed)

Created:
5 years, 6 months ago by sdefresne

Modified:
5 years, 6 months ago

Reviewers:
baxley, danakj, stevenjb, Eugene But (OOO till 7-30), kkhorimoto, stuartmorgan

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Added CGFloat comparison functions. (patchset #7 id:120001 of https://codereview.chromium.org/1155623002/) Reason for revert: Reverting because it cause the downstream waterfall to be flaky. Original issue's description: > Added CGFloat comparison functions. > > Comparing CGFloat values using direct equality was causing flakes in > CRWWebController's PageScrollState unittests, so compare using CGFloat's > epsilon. > > BUG=474290 > > Committed: https://crrev.com/53ce056bd3c312723adca2d3245d75a0599d904c > Cr-Commit-Position: refs/heads/master@{#332223} TBR=eugenebut@chromium.org,baxley@chromium.org,stuartmorgan@chromium.org,danakj@chromium.org,stevenjb@chromium.org,kkhorimoto@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474290 Committed: https://crrev.com/ae831473680c7287a7a24afebb8ed4f85e605a63 Cr-Commit-Position: refs/heads/master@{#332562}

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -22 lines)			Patch
M	ios/web/web_state/ui/crw_web_controller_unittest.mm	View	4 chunks	+7 lines, -12 lines	0 comments	Download
M	testing/gtest_mac.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	ui/gfx/test/ui_cocoa_test_helper.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/message_center/cocoa/tray_view_controller_unittest.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168523004/1

5 years, 6 months ago (2015-06-03 07:50:14 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-03 07:52:46 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ae831473680c7287a7a24afebb8ed4f85e605a63
Cr-Commit-Position: refs/heads/master@{#332562}