Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1168513004: [es6] Super call in arrows and eval (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
wingo, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Super call in arrows and eval This splits the SuperReference AST node into SuperPropertyReference and SuperCallReference. The super call reference node consists of three unresolved vars to this, new.target and this_function. These gets declared when the right function is entered and if it is in use. The variables gets assigned in FullCodeGenerator::Generate. This is a revert of the revert 88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8 BUG=v8:3768 LOG=N R=wingo@igalia.com, adamk@chromium.org Committed: https://crrev.com/4b8051a02ae9f765b7d803fc7986301abde36007 Cr-Commit-Position: refs/heads/master@{#28769}

Patch Set 1 #

Patch Set 2 : Push this_function earlier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+743 lines, -342 lines) Patch
M src/arm/full-codegen-arm.cc View 1 19 chunks +67 lines, -41 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 19 chunks +69 lines, -41 lines 0 comments Download
M src/ast.h View 5 chunks +47 lines, -11 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-numbering.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +10 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 19 chunks +68 lines, -41 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 19 chunks +66 lines, -41 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 19 chunks +66 lines, -41 lines 0 comments Download
M src/parser.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/parser.cc View 3 chunks +32 lines, -9 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.h View 4 chunks +12 lines, -6 lines 0 comments Download
M src/prettyprinter.cc View 3 chunks +19 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scopes.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/scopes.cc View 5 chunks +54 lines, -48 lines 0 comments Download
M src/typing.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/variables.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 19 chunks +67 lines, -40 lines 0 comments Download
M test/mjsunit/harmony/super.js View 2 chunks +97 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
Push this_function earlier
5 years, 6 months ago (2015-06-02 20:59:04 UTC) #1
arv (Not doing code reviews)
PTAL Patchset 1 is a revert of the revert. Patchset 2 moves the push of ...
5 years, 6 months ago (2015-06-02 21:05:37 UTC) #2
adamk
lgtm
5 years, 6 months ago (2015-06-02 21:06:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168513004/20001
5 years, 6 months ago (2015-06-02 21:16:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 22:04:34 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 22:04:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b8051a02ae9f765b7d803fc7986301abde36007
Cr-Commit-Position: refs/heads/master@{#28769}

Powered by Google App Engine
This is Rietveld 408576698