Oilpan: Remove PersistentBase

Oilpan: Remove PersistentBase

This is a preparation for removing a vtable from the Persistent hierarchy.
This CL removes PersistentBase. This CL just moves the logic of the PersistentBase
to Persistent, CrossThreadPersistent and PersistentHeapCollection.
No change in behavior.

BUG=483380
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196729

[haraken, 2015-06-08 04:31:29]

haraken@chromium.org changed reviewers:
+ keishi@chromium.org, oilpan-reviews@chromium.org

[haraken, 2015-06-08 04:31:29]

PTAL

https://codereview.chromium.org/1168503008/diff/1/Source/platform/heap/Handle.h
File Source/platform/heap/Handle.h (right):

https://codereview.chromium.org/1168503008/diff/1/Source/platform/heap/Handle...
Source/platform/heap/Handle.h:155: Persistent() :
PersistentNode(TraceMethodDelegate<Persistent<T>,
&Persistent<T>::trace>::trampoline), m_raw(nullptr)

It is unfortunate that we have to write "TraceMethodDelegate<Persistent<T>,
&Persistent<T>::trace>::trampoline" every time.

At first, I tried to introduce:

  using Delegate = TraceMethodDelegate<Persistent<T>, &Persistent<T>::trace>;

but this didn't work because the using statement requires a full definition of T
(which means that we need to include T.h when using Persistent<T>).

Thus I decided just to use "TraceMethodDelegate<Persistent<T>,
&Persistent<T>::trace>::trampoline".

[keishi, 2015-06-08 05:22:42]

LGTM

[haraken, 2015-06-08 05:31:28]

Will wait for the oilpan tree get green (i.e., land
https://codereview.chromium.org/1164753004/) and land.

[haraken, 2015-06-08 23:47:51]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-06-08 23:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168503008/1

[commit-bot: I haz the power, 2015-06-09 00:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 00:53:34]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)

[haraken, 2015-06-09 00:58:49]

The CQ bit was checked by haraken@chromium.org

[haraken, 2015-06-09 00:58:49]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1168503008/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-06-09 00:59:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1168503008/20001

[commit-bot: I haz the power, 2015-06-09 03:03:05]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196729