Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1168503003: Kill unused IPDF_ classes. (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill unused IPDF_ classes. Some are simply never defined. Some are never instantiated. Some have paths that are never reached. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/80b597d3f32ef2509627c7561abb84a6f5ac09bf

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -107 lines) Patch
M core/include/fpdfapi/fpdf_module.h View 3 chunks +24 lines, -23 lines 1 comment Download
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +0 lines, -8 lines 1 comment Download
M core/include/fpdfapi/fpdf_render.h View 4 chunks +0 lines, -26 lines 2 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 1 chunk +4 lines, -4 lines 1 comment Download
M core/include/fpdftext/fpdf_text.h View 3 chunks +5 lines, -4 lines 1 comment Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, more cleanup. https://codereview.chromium.org/1168503003/diff/1/core/include/fpdfapi/fpdf_module.h File core/include/fpdfapi/fpdf_module.h (left): https://codereview.chromium.org/1168503003/diff/1/core/include/fpdfapi/fpdf_module.h#oldcode123 core/include/fpdfapi/fpdf_module.h:123: class IPDF_FontMgr; note: IPDF_FontMgr is removed. ...
5 years, 6 months ago (2015-06-02 22:19:29 UTC) #2
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-02 22:44:55 UTC) #3
Tom Sepez
5 years, 6 months ago (2015-06-03 23:09:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
80b597d3f32ef2509627c7561abb84a6f5ac09bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698