[Fixit-Dec-2012] Auto-launch system-level Chrome post user-level Chrome self-destruction.

chrome/browser/chrome_browser_main_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_win.h"
 
 #include <windows.h>
 #include <shellapi.h>
 
 #include <algorithm>
@@ skipping 340 matching lines @@
         // system-level Chrome instead.
         const string16 text =
             l10n_util::GetStringUTF16(IDS_MACHINE_LEVEL_INSTALL_CONFLICT);
         const string16 caption = l10n_util::GetStringUTF16(IDS_PRODUCT_NAME);
         const UINT flags = MB_OK | MB_ICONERROR | MB_TOPMOST;
         ui::MessageBox(NULL, text, caption, flags);
       }
       CommandLine uninstall_cmd(
           InstallUtil::GetChromeUninstallCmd(false, dist->GetType()));
       if (!uninstall_cmd.GetProgram().empty()) {
+        uninstall_cmd.AppendSwitch(installer::switches::kSelfDestruct);
         uninstall_cmd.AppendSwitch(installer::switches::kForceUninstall);
         uninstall_cmd.AppendSwitch(
             installer::switches::kDoNotRemoveSharedItems);
-        base::LaunchOptions launch_options;
+
+        const FilePath setup_exe(uninstall_cmd.GetProgram());
+        const string16 params(uninstall_cmd.GetArgumentsString());
+
+        SHELLEXECUTEINFO sei = { sizeof(sei) };

[grt (UTC plus 2), 2013/01/02 17:59:33]

For safety, I think you need:
        sei.fMask = SEE_MASK_NOASYNC;
see MSDN for details

[gab, 2013/01/02 21:15:48]

Done.

+        sei.nShow = SW_SHOWNORMAL;
+        sei.lpFile = setup_exe.value().c_str();
+        sei.lpParameters = params.c_str();

[grt (UTC plus 2), 2013/01/02 17:59:33]

MSDN says that quotes in lpParameters must be quoted by putting them in quotes
(e.g., " -> """). This isn't the quoting strategy used by
CommandLine::GetArgumentsString. I suspect we do this everywhere we call
ShellExecute, so maybe there's nothing to be done except to be aware of it and
hope that we never have a quoted string in the arguments.

[gab, 2013/01/02 21:15:48]

Interesting, if this is ever a problem (and if it is, it was already one) it
should be fixed in command_line.cc, not here imo.

[grt (UTC plus 2), 2013/01/03 15:41:27]

Yup. Wasn't suggesting that this was the place, just raising awareness.

+        // On Windows 8 SEE_MASK_FLAG_LOG_USAGE is necessary to guarantee we
+        // flip to the Desktop when launching.
         if (is_metro)
-          launch_options.force_breakaway_from_job_ = true;
-        base::LaunchProcess(uninstall_cmd, launch_options, NULL);
+          sei.fMask = SEE_MASK_FLAG_LOG_USAGE;

[grt (UTC plus 2), 2013/01/02 17:59:33]

= -> |=

[gab, 2013/01/02 21:15:48]

Done.

+
+        if (!::ShellExecuteExW(&sei))

[grt (UTC plus 2), 2013/01/02 17:59:33]

nit: please remove the trailing 'W'

[grt (UTC plus 2), 2013/01/02 17:59:33]

MSDN suggests that COM should always be initialized, although perhaps it isn't
needed in this case since lpFile is the executable itself. I don't know if the
shell could decide to load up an extension for even this simple case. I'll add
Robert since he has more in-the-shell knowledge than I do.

[robertshield, 2013/01/02 19:36:06]

This should be fine.  

[gab, 2013/01/02 21:15:48]

Done.

[gab, 2013/01/02 21:15:48]

Ack.

+          NOTREACHED();

[grt (UTC plus 2), 2013/01/02 17:59:33]

DPCHECK(false); so that the last-error code is logged.

[gab, 2013/01/02 21:15:48]

Done.

       }
       return true;
     }
   }
   return false;
 }
 
 string16 TranslationDelegate::GetLocalizedString(int installer_string_id) {
   int resource_id = 0;
   switch (installer_string_id) {
@@ skipping 11 matching lines @@
   if (resource_id)
     return l10n_util::GetStringUTF16(resource_id);
   return string16();
 }
 
 // static
 void ChromeBrowserMainPartsWin::SetupInstallerUtilStrings() {
   CR_DEFINE_STATIC_LOCAL(TranslationDelegate, delegate, ());
   installer::SetTranslationDelegate(&delegate);
 }