Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 1168483003: Thread-local store buffers, v2 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index 5837c8074adb28352a4e3b7adae25ce5d4d4d29a..4434d4c142fec8b83ed93dc8c39df4ea46b46d37 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -954,17 +954,11 @@ void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
__ LockCmpxchgl(FieldAddress(EDX, Object::tags_offset()), ECX);
__ j(NOT_EQUAL, &reload);
- // Load the isolate.
- // Spilled: EAX, ECX
- // EDX: Address being stored
- __ LoadIsolate(EAX);
-
- // Load the StoreBuffer block out of the isolate. Then load top_ out of the
+ // Load the StoreBuffer block out of the thread. Then load top_ out of the
// StoreBufferBlock and add the address to the pointers_.
// Spilled: EAX, ECX
// EDX: Address being stored
- // EAX: Isolate
- __ movl(EAX, Address(EAX, Isolate::store_buffer_offset()));
+ __ movl(EAX, Address(THR, Thread::store_buffer_block_offset()));
__ movl(ECX, Address(EAX, StoreBufferBlock::top_offset()));
__ movl(Address(EAX, ECX, TIMES_4, StoreBufferBlock::pointers_offset()), EDX);
@@ -988,8 +982,7 @@ void StubCode::GenerateUpdateStoreBufferStub(Assembler* assembler) {
// Setup frame, push callee-saved registers.
__ EnterCallRuntimeFrame(1 * kWordSize);
- __ LoadIsolate(EDX);
- __ movl(Address(ESP, 0), EDX); // Push the isolate as the only argument.
+ __ movl(Address(ESP, 0), THR); // Push the thread as the only argument.
__ CallRuntime(kStoreBufferBlockProcessRuntimeEntry, 1);
// Restore callee-saved registers, tear down frame.
__ LeaveCallRuntimeFrame();
« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698