Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1168483002: Fix motion event pressure checking in unit tests. (Closed)

Created:
5 years, 6 months ago by USE eero AT chromium.org
Modified:
5 years, 6 months ago
Reviewers:
jdduke (slow), sadrul, sky
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix motion event pressure checking in unit tests. This fixes motion event test utils to report motion event pressure (instead of orientation) as pressure. Committed: https://crrev.com/88b5c19ab91844bad7dd993533c1427bff29002d Cr-Commit-Position: refs/heads/master@{#332594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/events/test/motion_event_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
USE eero AT chromium.org
A small correction. PTAL.
5 years, 6 months ago (2015-06-02 14:51:35 UTC) #2
jdduke (slow)
On 2015/06/02 14:51:35, e_hakkinen wrote: > A small correction. PTAL. lgtm
5 years, 6 months ago (2015-06-02 14:54:04 UTC) #3
sky
LGTM
5 years, 6 months ago (2015-06-02 16:21:03 UTC) #4
sky
In the future you don't need 3 reviewers for patches like this.
5 years, 6 months ago (2015-06-02 16:21:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168483002/1
5 years, 6 months ago (2015-06-03 08:07:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/89891)
5 years, 6 months ago (2015-06-03 09:37:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168483002/1
5 years, 6 months ago (2015-06-03 11:05:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 11:47:02 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:48:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88b5c19ab91844bad7dd993533c1427bff29002d
Cr-Commit-Position: refs/heads/master@{#332594}

Powered by Google App Engine
This is Rietveld 408576698