Source/core/css/parser/CSSPropertyParserTest.cpp - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParserTest.cpp

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSPropertyParserTest.cpp

diff --git a/Source/core/css/parser/CSSPropertyParserTest.cpp b/Source/core/css/parser/CSSPropertyParserTest.cpp

index 4b19f349aee20d762eb7d5e316a7567b58a6cdc7..dc58ef3e9f609b957764f3feb1df5b032394f969 100644

--- a/Source/core/css/parser/CSSPropertyParserTest.cpp

+++ b/Source/core/css/parser/CSSPropertyParserTest.cpp

@@ -34,14 +34,14 @@ TEST(CSSPropertyParserTest, GridTrackLimits)

{CSSPropertyGridTemplateRows, "repeat(999999, 20px)", 999999},

{CSSPropertyGridTemplateColumns, "repeat(1000000, 10%)", 1000000},

{CSSPropertyGridTemplateRows, "repeat(1000000, 10%)", 1000000},

- {CSSPropertyGridTemplateColumns, "repeat(1000000, (first) min-content (last))", 1000000},

- {CSSPropertyGridTemplateRows, "repeat(1000000, (first) min-content (last))", 1000000},

+ {CSSPropertyGridTemplateColumns, "repeat(1000000, [first] min-content [last])", 1000000},

+ {CSSPropertyGridTemplateRows, "repeat(1000000, [first] min-content [last])", 1000000},

{CSSPropertyGridTemplateColumns, "repeat(1000001, auto)", 1000000},

{CSSPropertyGridTemplateRows, "repeat(1000001, auto)", 1000000},

{CSSPropertyGridTemplateColumns, "repeat(400000, 2em minmax(10px, max-content) 0.5fr)", 999999},

{CSSPropertyGridTemplateRows, "repeat(400000, 2em minmax(10px, max-content) 0.5fr)", 999999},

- {CSSPropertyGridTemplateColumns, "repeat(600000, (first) 3vh 10% 2fr (nav) 10px auto 1fr 6em (last))", 999999},

- {CSSPropertyGridTemplateRows, "repeat(600000, (first) 3vh 10% 2fr (nav) 10px auto 1fr 6em (last))", 999999},

+ {CSSPropertyGridTemplateColumns, "repeat(600000, [first] 3vh 10% 2fr [nav] 10px auto 1fr 6em [last])", 999999},

+ {CSSPropertyGridTemplateRows, "repeat(600000, [first] 3vh 10% 2fr [nav] 10px auto 1fr 6em [last])", 999999},

{CSSPropertyGridTemplateColumns, "repeat(100000000000000000000, 10% 1fr)", 1000000},

{CSSPropertyGridTemplateRows, "repeat(100000000000000000000, 10% 1fr)", 1000000},

{CSSPropertyGridTemplateColumns, "repeat(100000000000000000000, 10% 5em 1fr auto auto 15px min-content)", 999999},

« no previous file with comments | « Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »