Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing v2 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html b/LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html
index 7e23dfaf919f4ad5949eb55dec51b0b885de549e..6b3780e3e34c6518882821e00dcaf6be9b5e8ca0 100644
--- a/LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/non-grid-element-repeat-get-set.html
@@ -19,33 +19,33 @@
}
.twoDoubleTrackWithNamedGridLineRepeat {
- grid-template-rows: repeat(2, 10px (start) auto (end));
- grid-template-columns: repeat(2, auto (middle) 250px (end));
+ grid-template-rows: repeat(2, 10px [start] auto [end]);
+ grid-template-columns: repeat(2, auto [middle] 250px [end]);
}
.twoDoubleTrackWithTrailingNamedGridLineRepeat {
- grid-template-rows: repeat(2, (before) 10px);
- grid-template-columns: repeat(2, (before) auto);
+ grid-template-rows: repeat(2, [before] 10px);
+ grid-template-columns: repeat(2, [before] auto);
}
.trailingNamedGridLineRepeat {
- grid-template-rows: repeat(1, 10px) (end);
- grid-template-columns: repeat(1, 250px) (end);
+ grid-template-rows: repeat(1, 10px) [end];
+ grid-template-columns: repeat(1, 250px) [end];
}
.leadingNamedGridLineRepeat {
- grid-template-rows: (start) repeat(2, 10px);
- grid-template-columns: (start) repeat(2, 250px);
+ grid-template-rows: [start] repeat(2, 10px);
+ grid-template-columns: [start] repeat(2, 250px);
}
.mixRepeatAfterNonRepeat {
grid-template-rows: auto repeat(2, 10px);
- grid-template-columns: (start) 140px repeat(2, 250px);
+ grid-template-columns: [start] 140px repeat(2, 250px);
}
.mixNonRepeatAfterRepeat {
- grid-template-rows: repeat(2, 10px) (end) auto;
- grid-template-columns: repeat(2, 250px) 15% (last);
+ grid-template-rows: repeat(2, 10px) [end] auto;
+ grid-template-columns: repeat(2, 250px) 15% [last];
}
</style>
<script src="../../resources/js-test.js"></script>
@@ -69,12 +69,12 @@
testGridDefinitionsValues(document.getElementById("singleSingleTrackRepeat"), "15%", "18px");
testGridDefinitionsValues(document.getElementById("twoSingleTrackRepeat"), "minmax(15px, 50%) minmax(15px, 50%)", "auto auto");
testGridDefinitionsValues(document.getElementById("twoDoubleTrackRepeat"), "auto minmax(100px, 120px) auto minmax(100px, 120px)", "minmax(5px, 10px) auto minmax(5px, 10px) auto");
- testGridDefinitionsValues(document.getElementById("twoDoubleTrackWithNamedGridLineRepeat"), "auto (middle) 250px (end) auto (middle) 250px (end)", "10px (start) auto (end) 10px (start) auto (end)");
- testGridDefinitionsValues(document.getElementById("twoDoubleTrackWithTrailingNamedGridLineRepeat"), "(before) auto (before) auto", "(before) 10px (before) 10px");
- testGridDefinitionsValues(document.getElementById("trailingNamedGridLineRepeat"), "250px (end)", "10px (end)");
- testGridDefinitionsValues(document.getElementById("leadingNamedGridLineRepeat"), "(start) 250px 250px", "(start) 10px 10px");
- testGridDefinitionsValues(document.getElementById("mixRepeatAfterNonRepeat"), "(start) 140px 250px 250px", "auto 10px 10px");
- testGridDefinitionsValues(document.getElementById("mixNonRepeatAfterRepeat"), "250px 250px 15% (last)", "10px 10px (end) auto");
+ testGridDefinitionsValues(document.getElementById("twoDoubleTrackWithNamedGridLineRepeat"), "auto [middle] 250px [end] auto [middle] 250px [end]", "10px [start] auto [end] 10px [start] auto [end]");
+ testGridDefinitionsValues(document.getElementById("twoDoubleTrackWithTrailingNamedGridLineRepeat"), "[before] auto [before] auto", "[before] 10px [before] 10px");
+ testGridDefinitionsValues(document.getElementById("trailingNamedGridLineRepeat"), "250px [end]", "10px [end]");
+ testGridDefinitionsValues(document.getElementById("leadingNamedGridLineRepeat"), "[start] 250px 250px", "[start] 10px 10px");
+ testGridDefinitionsValues(document.getElementById("mixRepeatAfterNonRepeat"), "[start] 140px 250px 250px", "auto 10px 10px");
+ testGridDefinitionsValues(document.getElementById("mixNonRepeatAfterRepeat"), "250px 250px 15% [last]", "10px 10px [end] auto");
debug("");
debug("Test invalid repeat syntax.");

Powered by Google App Engine
This is Rietveld 408576698