LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks-expected.txt ('k') | LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

diff --git a/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html b/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

index 95cdcef5d54cda1e752a79714eef6b64cc9b3ecc..be2fc31765d503e15b2da6af46aa3d1ac4f3bb03 100644

--- a/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

+++ b/LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html

@@ -50,12 +50,12 @@ function updateRowsColumns()

var templateAreaOne = '". a a" "c a a" ". . d"';

var templateAreaTwo = '". d d" "a d d" ". . c"';

- var columnUniqueNames = '(a) 50px (b b-start) 100px (c -start) 200px (d)';

- var rowUniqueNames = '(e) 50px (f -end) 100px (g g-start) 200px (h)';

- var columnNamedLineBeforeArea = '(a-start c-start) 50px (d-start) 100px 200px';

- var rowNamedLineBeforeArea = '(c-start) 50px (d-start) 100px 200px';

- var columnRepeatedNames = '(d-start) 50px (d-start) 100px (d-start) 200px';

- var rowRepeatedNames = '50px (c-end) 100px (c-end) 200px (c-end)';

+ var columnUniqueNames = '[a] 50px [b b-start] 100px [c -start] 200px [d]';

+ var rowUniqueNames = '[e] 50px [f -end] 100px [g g-start] 200px [h]';

+ var columnNamedLineBeforeArea = '[a-start c-start] 50px [d-start] 100px 200px';

+ var rowNamedLineBeforeArea = '[c-start] 50px [d-start] 100px 200px';

+ var columnRepeatedNames = '[d-start] 50px [d-start] 100px [d-start] 200px';

+ var rowRepeatedNames = '50px [c-end] 100px [c-end] 200px [c-end]';

var columnNoNames = '50px 100px 200px';

var rowNoNames = '50px 100px 200px';