Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing v2 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html
diff --git a/LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html b/LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html
index 1d8a95c5c8d8751a99b98af459759013b274cacd..6aa8c8f5fc5a026f5d642e32977e75f1ce7b1ca3 100644
--- a/LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html
+++ b/LayoutTests/fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html
@@ -6,13 +6,13 @@
}
.singleNamedGridLines {
- grid-template-columns: (a) auto (b);
- grid-template-rows: (x) auto (y);
+ grid-template-columns: [a] auto [b];
+ grid-template-rows: [x] auto [y];
}
.multipleNamedGridLines {
- grid-template-columns: (a b c) auto (d e);
- grid-template-rows: (x y z) auto (v w);
+ grid-template-columns: [a b c] auto [d e];
+ grid-template-rows: [x y z] auto [v w];
}
</style>
<script src="../../resources/js-test.js"></script>
@@ -77,13 +77,13 @@
<script>
description("Test that computed style for grid-template-columns and grid-template-rows works as expected with named grid lines and implicit tracks");
- testGridDefinitionsValues(document.getElementById("gridOneColumnSingle"), "(a) 200px (b)", "(x) 50px (y) 50px 50px 50px");
- testGridDefinitionsValues(document.getElementById("gridTwoColumnsSingle"), "(a) 200px (b) 150px", "(x) 50px (y) 50px");
- testGridDefinitionsValues(document.getElementById("gridThreeColumnsSingle"), "(a) 200px (b) 150px 100px", "(x) 50px (y) 50px");
- testGridDefinitionsValues(document.getElementById("gridFourColumnsSingle"), "(a) 200px (b) 150px 100px 50px", "(x) 50px (y)");
+ testGridDefinitionsValues(document.getElementById("gridOneColumnSingle"), "[a] 200px [b]", "[x] 50px [y] 50px 50px 50px");
+ testGridDefinitionsValues(document.getElementById("gridTwoColumnsSingle"), "[a] 200px [b] 150px", "[x] 50px [y] 50px");
+ testGridDefinitionsValues(document.getElementById("gridThreeColumnsSingle"), "[a] 200px [b] 150px 100px", "[x] 50px [y] 50px");
+ testGridDefinitionsValues(document.getElementById("gridFourColumnsSingle"), "[a] 200px [b] 150px 100px 50px", "[x] 50px [y]");
- testGridDefinitionsValues(document.getElementById("gridOneColumnMultiple"), "(a b c) 200px (d e)", "(x y z) 50px (v w) 50px 50px 50px");
- testGridDefinitionsValues(document.getElementById("gridTwoColumnsMultiple"), "(a b c) 200px (d e) 150px", "(x y z) 50px (v w) 50px");
- testGridDefinitionsValues(document.getElementById("gridThreeColumnsMultiple"), "(a b c) 200px (d e) 150px 100px", "(x y z) 50px (v w) 50px");
- testGridDefinitionsValues(document.getElementById("gridFourColumnsMultiple"), "(a b c) 200px (d e) 150px 100px 50px", "(x y z) 50px (v w)");
+ testGridDefinitionsValues(document.getElementById("gridOneColumnMultiple"), "[a b c] 200px [d e]", "[x y z] 50px [v w] 50px 50px 50px");
+ testGridDefinitionsValues(document.getElementById("gridTwoColumnsMultiple"), "[a b c] 200px [d e] 150px", "[x y z] 50px [v w] 50px");
+ testGridDefinitionsValues(document.getElementById("gridThreeColumnsMultiple"), "[a b c] 200px [d e] 150px 100px", "[x y z] 50px [v w] 50px");
+ testGridDefinitionsValues(document.getElementById("gridFourColumnsMultiple"), "[a b c] 200px [d e] 150px 100px 50px", "[x y z] 50px [v w]");
</script>

Powered by Google App Engine
This is Rietveld 408576698