LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-named-grid-line-resolution.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <link href="resources/grid.css" rel="stylesheet">	4 <link href="resources/grid.css" rel="stylesheet">

5 <style>	5 <style>

6 .grid {	6 .grid {

7 grid-template-rows: (before) 50px (middle) 100px (after) 150px;	7 grid-template-rows: [before] 50px [middle] 100px [after] 150px;

8 grid-template-columns: 40px 80px 160px;	8 grid-template-columns: 40px 80px 160px;

9 }	9 }

10	10

11 .gridWithoutRepeat {	11 .gridWithoutRepeat {

12 grid-template-areas: "first second third"	12 grid-template-areas: "first second third"

13 "fourth fifth sixth";	13 "fourth fifth sixth";

14 }	14 }

15	15

16 .gridWithRepeat {	16 .gridWithRepeat {

17 grid-template-areas: "first second third"	17 grid-template-areas: "first second third"

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 <div class="sizedToGridArea gridItemSecondArea" data-offset-x="40" data- offset-y="0" data-expected-width="80" data-expected-height="50"></div>	83 <div class="sizedToGridArea gridItemSecondArea" data-offset-x="40" data- offset-y="0" data-expected-width="80" data-expected-height="50"></div>

84 <div class="sizedToGridArea gridItemFirstArea" data-offset-x="0" data-of fset-y="0" data-expected-width="40" data-expected-height="50"></div>	84 <div class="sizedToGridArea gridItemFirstArea" data-offset-x="0" data-of fset-y="0" data-expected-width="40" data-expected-height="50"></div>

85	85

86 <div class="sizedToGridArea gridItemSpan2ThirdArea" data-offset-x="40" d ata-offset-y="50" data-expected-width="240" data-expected-height="100"></div>	86 <div class="sizedToGridArea gridItemSpan2ThirdArea" data-offset-x="40" d ata-offset-y="50" data-expected-width="240" data-expected-height="100"></div>

87 <div class="sizedToGridArea gridItemNamedGridLineWithArea" data-offset-x ="0" data-offset-y="0" data-expected-width="40" data-expected-height="150"></div >	87 <div class="sizedToGridArea gridItemNamedGridLineWithArea" data-offset-x ="0" data-offset-y="0" data-expected-width="40" data-expected-height="150"></div >

88 </div>	88 </div>

89 </div>	89 </div>

90	90

91 </body>	91 </body>

92 </html>	92 </html>

OLD	NEW