LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <link href="resources/grid.css" rel="stylesheet">	4 <link href="resources/grid.css" rel="stylesheet">

5 <style>	5 <style>

6 .grid {	6 .grid {

7 grid-template-areas: "firstArea secondArea"	7 grid-template-areas: "firstArea secondArea"

8 "thirdArea thirdArea";	8 "thirdArea thirdArea";

9	9

10 grid-template-columns: (first nav) 10px 10px;	10 grid-template-columns: [first nav] 10px 10px;

11 grid-template-rows: (last) 10px 10px;	11 grid-template-rows: [last] 10px 10px;

12 }	12 }

13	13

14 .gridItemWithPositiveInteger {	14 .gridItemWithPositiveInteger {

15 grid-column: 10;	15 grid-column: 10;

16 grid-row: 15;	16 grid-row: 15;

17 }	17 }

18 .gridItemWithNegativeInteger {	18 .gridItemWithNegativeInteger {

19 grid-column: -10;	19 grid-column: -10;

20 grid-row: -15;	20 grid-row: -15;

21 }	21 }

(...skipping 210 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
232 testColumnRowInvalidJSParsing("0 / span 0", "0 / 0 span");	232 testColumnRowInvalidJSParsing("0 / span 0", "0 / 0 span");

233 testColumnRowInvalidJSParsing("span -3 'first' / 3 last", "last -2 span / 1 nav");	233 testColumnRowInvalidJSParsing("span -3 'first' / 3 last", "last -2 span / 1 nav");

234	234

235 // We don't allow span to be between the <integer> and the <string>.	235 // We don't allow span to be between the <integer> and the <string>.

236 testColumnRowInvalidJSParsing("first span 1 / last", "2 span first / last");	236 testColumnRowInvalidJSParsing("first span 1 / last", "2 span first / last");

237 testColumnRowInvalidJSParsing("3 first / 2 span last", "5 nav / last span 7" );	237 testColumnRowInvalidJSParsing("3 first / 2 span last", "5 nav / last span 7" );

238 testColumnRowInvalidJSParsing("3 / 1 span 2", "5 / 3 span 3");	238 testColumnRowInvalidJSParsing("3 / 1 span 2", "5 / 3 span 3");

239 </script>	239 </script>

240 </body>	240 </body>

241 </html>	241 </html>

OLD	NEW