LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html - Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html

Issue 1168453002: [CSSGridLayout] Switch from parentheses to brackets for grid line names (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing v2 Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-item-auto-placement-automatic-span.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <link href="resources/grid.css" rel="stylesheet">	3 <link href="resources/grid.css" rel="stylesheet">

4 <style>	4 <style>

5 .grid {	5 .grid {

6 grid-template-rows: (firstRow) 10px 20px;	6 grid-template-rows: [firstRow] 10px 20px;

7 grid-template-columns: (firstColumn) 30px 40px;	7 grid-template-columns: [firstColumn] 30px 40px;

8 grid-auto-flow: row;	8 grid-auto-flow: row;

9 }	9 }

10	10

11 .bothSpanRow {	11 .bothSpanRow {

12 grid-column: 1;	12 grid-column: 1;

13 grid-row: span 5 firstRow / span 1;	13 grid-row: span 5 firstRow / span 1;

14 }	14 }

15	15

16 .bothSpanColumn {	16 .bothSpanColumn {

17 grid-column: span / span 3;	17 grid-column: span / span 3;

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56	56

57 <div style="position: relative">	57 <div style="position: relative">

58 <div class="grid">	58 <div class="grid">

59 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>	59 <div class="sizedToGridArea firstRowFirstColumn" data-offset-x="0" data- offset-y="0" data-expected-width="30" data-expected-height="10"></div>

60 <div class="sizedToGridArea spanAutoColumn" data-offset-x="30" data-offs et-y="0" data-expected-width="40" data-expected-height="10"></div>	60 <div class="sizedToGridArea spanAutoColumn" data-offset-x="30" data-offs et-y="0" data-expected-width="40" data-expected-height="10"></div>

61 </div>	61 </div>

62 </div>	62 </div>

63	63

64 </body>	64 </body>

65 </html>	65 </html>

OLD	NEW