Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1168433003: Update vs2015 toolchain hash (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@toolchain-update
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update vs2015 toolchain hash Missed some files in the last version. (Corresponds to ps#8 in https://codereview.chromium.org/1165563003/ ) TBR=dpranke@chromium.org BUG=492774, 440500 Committed: https://crrev.com/176353a4bceff74ca34d6ebd0708b8894cda6d73 Cr-Commit-Position: refs/heads/master@{#332339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
scottmg
(tbr since this isn't really usefully reviewable)
5 years, 6 months ago (2015-06-02 02:42:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168433003/1
5 years, 6 months ago (2015-06-02 02:43:21 UTC) #3
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-02 02:59:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 03:22:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1168433003/1
5 years, 6 months ago (2015-06-02 03:26:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 03:32:31 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 03:34:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/176353a4bceff74ca34d6ebd0708b8894cda6d73
Cr-Commit-Position: refs/heads/master@{#332339}

Powered by Google App Engine
This is Rietveld 408576698